New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ko.abbrev.findAbbrevSnippet broken in 10.2 #2373

Closed
babobski opened this Issue Feb 24, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@babobski
Contributor

babobski commented Feb 24, 2017

Short Summary

ko.abbrev.findAbbrevSnippet no longer working properly. I have a custom addon for my self that uses
ko.abbrev.findAbbrevSnippet only it fails for all my custom abbreviations:

afbeelding

afbeelding

afbeelding

afbeelding

afbeelding

For PHP it is only working for abbreviations that are in the default folder:

afbeelding

Steps to Reproduce

The snippets I'm using can be found here.
@cgchoffman noticed that the 'import > import folder from file system' is working correct, it is setting the correct languages for the imports.

Platform Information

Komodo Ide 10.2 Windows 10

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Feb 24, 2017

Why are you setting the Sub language for the search? You should only need ko.abbrev.findAbbrevSnippet(snippetName, language).

@Naatan

This comment has been minimized.

Member

Naatan commented Feb 24, 2017

@cgchoffman the point is it should be backwards compatible, we'll need to ensure that if this worked before it still works now.

@Naatan Naatan added this to the 10.2.1 milestone Feb 24, 2017

cgchoffman added a commit that referenced this issue Feb 24, 2017

Toolbox: use isAutoAbbrev variable. Fixes #2373
rn=

(integrated from the KomodoIDE 10.2.x branch change 41bb163 by Carey Hoffman <cgchoffman@gmail.com>)

Komodo/KomodoIDE@41bb163
@babobski

This comment has been minimized.

Contributor

babobski commented Feb 26, 2017

@cgchoffman If i use the ko.abbrev.findAbbrevSnippet(snippetName, language) command, It still doesn't work.

afbeelding

And the structure:

afbeelding

The snippets:

afbeelding

afbeelding

afbeelding

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Feb 27, 2017

@cgchoffman If i use the ko.abbrev.findAbbrevSnippet(snippetName, language) command, It still doesn't work.

Yes I was wrong. The issue is fixed now and will be in the next nightly.

And the structure:

Toolbox folder structure has no effect on snippets any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment