New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language undefined warning when saving snippets #2375

Closed
Naatan opened this Issue Feb 27, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@Naatan
Member

Naatan commented Feb 27, 2017

Open a snippet and press OK, check log for following warning:

JavaScript strict warning: chrome://komodo/content/project/snippetProperties.js, line 270: ReferenceError: assignment to undeclared variable language
@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Feb 27, 2017

@Naatan I'm pretty sure those warnings are on Master and are due to the changes you made for Komodo 11 nathanr. Can you confirm what build you're using?

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Feb 27, 2017

Also the error you posted isn't a "language undefined error". It's an "undeclared var" error. I can't reproduce either error on 10.2.

cgchoffman added a commit that referenced this issue Feb 27, 2017

Toolbox: undeclared variable on snippet save: fixes #2375
rn=

(integrated from the KomodoIDE 10.2.x branch change 6c552af by Carey Hoffman <cgchoffman@gmail.com>)

Komodo/KomodoIDE@6c552af

@cgchoffman cgchoffman reopened this Feb 27, 2017

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Feb 27, 2017

undelcared variable error is fixed but can you confirm my question in my first comment @Naatan ?

@Naatan

This comment has been minimized.

Member

Naatan commented Feb 27, 2017

@cgchoffman yeah I'm using master. So is the commit you did for something else?

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Feb 27, 2017

@Naatan, you referenced two different errors. I fixed one of them. The title error is a different errror that is only on Master. The one i fixed I've noticed before but it doesn't effect snippet saving at all but you labelled this for 10.2.1 so I fixed it.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Feb 27, 2017

I was reading too much into error messages and bug titles. I thought @Naatan was talking about another error that I've seen on Master.

@cgchoffman cgchoffman closed this Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment