New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commando opens and instantly closes #2452

Closed
lagbox opened this Issue Apr 5, 2017 · 12 comments

Comments

Projects
None yet
4 participants
@lagbox
Contributor

lagbox commented Apr 5, 2017

Short Summary

When using keybindings or clicking the commando input, commando starts to show then instantly disappears, similar to if you started it then cancelled.

Steps to Reproduce

For me, just activating anything related to commando. Click the input.

Expected results

Commando to stay open and active

Actual results

Commando closes itself instantly.

Platform Information

Komodo Edit or IDE? Komodo IDE
Komodo Version? version 10.2.2, build 89878, platform linux-x86_64. Built on Tue Apr 4 23:34:04 2017.
Operating System (and version)? Ubuntu 16.10

Additional Information

pystderr.log.txt

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Apr 5, 2017

Anything in the log?

@lagbox

This comment has been minimized.

Contributor

lagbox commented Apr 5, 2017

added pystderr

@Naatan

This comment has been minimized.

Member

Naatan commented Apr 5, 2017

Can you reproduce this using Help > Troubleshooting > Restart in Safe-mode ?

Please verify that when restarting in safe-mode Komodo should be using the default UI (all your settings would be temporarily reset).

@lagbox

This comment has been minimized.

Contributor

lagbox commented Apr 6, 2017

Same in Safe-Mode

@Naatan

This comment has been minimized.

Member

Naatan commented Apr 6, 2017

Could you try the following:

  • Shut down Komodo
  • Locate and open /lib/mozilla/extensions/commando@activestate.com.xpi
  • From that archive open content/sdk/commando.js
  • Find this.hide = function()
  • Inside the function add console.trace();
  • Start Komodo and reproduce the issue, share the output of your Console widget (bottom pane).
@lagbox

This comment has been minimized.

Contributor

lagbox commented Apr 6, 2017

String "trace: trace _ent/sdk/commando.js 724 this.hide _ .."
    trace: 
    trace 
    _ent/sdk/commando.js 724 this.hide 
    _ent/sdk/commando.js 164 init/< 
        0

String "trace: trace _ent/sdk/commando.js 724 this.hide _ .."
    trace: 
    trace 
    _ent/sdk/commando.js 724 this.hide 
    _ent/sdk/commando.js 164 init/< 
        0 
@AllieBunny

This comment has been minimized.

AllieBunny commented Apr 6, 2017

I have this same issue, running just the .exe I got from the download page.

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Apr 6, 2017

I have the same issue. The latest nightly is the version.

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Apr 6, 2017

Built Komodo myself (from master), changed log level of commando logger to debug, here's the output:

[2017-04-06 14:25:03,147] [DEBUG] commando: Showing Commando
[2017-04-06 14:25:03,190] [DEBUG] commando: Executing scope handler: onShow on scope-combined/everything
[2017-04-06 14:25:03,190] [DEBUG] commando: onShow not found in scope, skipping
[2017-04-06 14:25:03,209] [DEBUG] commando: Event: onSearch
[2017-04-06 14:25:03,219] [DEBUG] commando: Hiding Commando
[2017-04-06 14:25:03,260] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,273] [DEBUG] commando: Event: onSearch - Timer Triggered
[2017-04-06 14:25:03,274] [DEBUG] commando: {287199aa-48fc-4ef7-a2a5-e2784c8c83a2} - Starting Search for: 
[2017-04-06 14:25:03,274] [DEBUG] commando: Executing scope handler: onSearch on scope-combined/everything
[2017-04-06 14:25:03,275] [DEBUG] commando: Executing onSearch on scope
[2017-04-06 14:25:03,275] [DEBUG] commando: Setting result timer
[2017-04-06 14:25:03,287] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,290] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,312] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,314] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,324] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,325] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,326] [DEBUG] commando: Triggering result timer
[2017-04-06 14:25:03,326] [DEBUG] commando: {287199aa-48fc-4ef7-a2a5-e2784c8c83a2} - Rendering 6 Results
[2017-04-06 14:25:03,333] [DEBUG] commando: Emptying Results
[2017-04-06 14:25:03,344] [DEBUG] commando: Executing scope handler: onPreview on scope-combined/everything
[2017-04-06 14:25:03,345] [DEBUG] commando: onPreview not found in scope, skipping
[2017-04-06 14:25:03,350] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,350] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,361] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,362] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,375] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,375] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,376] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,385] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,386] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,387] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,397] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,398] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,399] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,408] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,409] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,410] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,419] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,420] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,431] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,442] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,453] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,469] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:03,484] [DEBUG] commando: Can't grab focus, retrying
[2017-04-06 14:25:10,877] [DEBUG] commando: Hiding Commando
@Defman21

This comment has been minimized.

Contributor

Defman21 commented Apr 6, 2017

Reverting 7f6c424 fixes the problem.

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Apr 6, 2017

This patch fixes the bug for me, but I don't know about side effects.

diff --git a/src/modules/commando/content/sdk/commando.js b/src/modules/commando/content/sdk/commando.js
index c77c97998..9a16ac596 100644
--- a/src/modules/commando/content/sdk/commando.js
+++ b/src/modules/commando/content/sdk/commando.js
@@ -170,7 +170,8 @@
 
         window.addEventListener("click", onWindowClick);
         window.addEventListener("deactivate", function (e) {
-            c.hide();
+            if (!local.showing)
+                c.hide();
         });
     }
@Naatan

This comment has been minimized.

Member

Naatan commented Apr 6, 2017

Very nice, thanks @Defman21! I don't understand why deactivate is triggering while the window is still focussed, probably a XUL panel bug.

@Naatan Naatan closed this in fb80d06 Apr 6, 2017

@Naatan Naatan added this to the 10.2.2 milestone Apr 6, 2017

@Naatan Naatan self-assigned this Apr 6, 2017

Naatan added a commit that referenced this issue Apr 6, 2017

Commando: Fix regression where commando wouldn't stay open - fixes #2452


(integrated from the KomodoIDE master branch change 5c1a4c7e59 by Nathan Rijksen <n.rijksen@gmail.com>)

Komodo/KomodoIDE@5c1a4c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment