New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs not resizing (possibly Windows only) #2493

Closed
cgchoffman opened this Issue Apr 19, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@cgchoffman
Member

cgchoffman commented Apr 19, 2017

I'm getting dialogs that won't fit their content.

The following snippet dropped into the JS Console will produce the image below the snippet:

ko.dialogs.okCancel("sdfsdddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd")

image

Notes:

  • If you click Ok then run the code again it will fit the text, to reproduce the issue you have to change the text input then it will open not showing all the content.
@Defman21

This comment has been minimized.

Contributor

Defman21 commented Apr 19, 2017

It fits on Linux for me (both with native/komodo's decorations), so looks like a windows only issue.

@Naatan Naatan assigned cgchoffman and unassigned Naatan Apr 19, 2017

cgchoffman added a commit that referenced this issue Apr 19, 2017

Window: dialogs don't size to content. Fixes #2493
rn=

(integrated from the KomodoIDE 10.2.x branch change 8c2067e by Carey Hoffman <cgchoffman@gmail.com>)

Komodo/KomodoIDE@8c2067e
@mjainQA

This comment has been minimized.

mjainQA commented Apr 27, 2017

Verified on Windows and macOS with 10.2.2 RC3.

Added a test case - http://testrail.activestate.com/testrail/index.php?/cases/view/173

Defman21 added a commit to Defman21/KomodoEdit that referenced this issue May 4, 2017

Window: dialogs don't size to content. Fixes Komodo#2493
rn=

(integrated from the KomodoIDE 10.2.x branch change 8c2067e by Carey Hoffman <cgchoffman@gmail.com>)

https://github.com/Komodo/KomodoIDE/commit/8c2067e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment