Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Brace highlighting causes neighbor character's style to "flicker" #396
This happens whether or not soft characters are enabled.
Steps to Reproduce
Or hold the key down rather than tapping it:
Correct. Scintilla has a character buffer and a style buffer. The character buffer holds buffer text and the style buffer holds styles to draw characters in. They need to be resynchronized as text is inserted and removed, and it is very likely you are capturing Scintilla in the middle of a resynchronization attempt. I doubt there's anything we can do here.
The style sync'ing in this case occurs in views-buffer-base::onUpdateUI. The actual style updating occurs behind a
This would also explain why I can't reproduce the issue in SciTE or other Scintilla-based editors.
The update occurs in a
The changes were made in 2009, and it's not immediately clear to me what didn't work correctly then or whether the timeout is the most appropriate solution to that problem.
Concerning the flicker issue in particular: reducing the timeout delay to 5ms (from 50ms) made a visually significant reduction to the flicker. Even in the extreme case of holding down the key to force a repeat, the shorter delay made the problem surprisingly less noticeable.
referenced this issue
Jul 6, 2015
Thanks for digging into that @ervumlens ! I just spoke about it with Mitchell and he thinks its too risky to fix this for the upcoming build, as Komodo does a lot of things with Scintilla under the hood. We'd need to test over a longer period of time whether removing that delay causes any nasty issues that may not be immediately obvious.
So we'll definitely look into this, just not for 9.2.