vi mode: editor view doesn't scroll down when selecting down #436

Closed
trentm opened this Issue Jul 20, 2015 · 2 comments

Comments

Projects
None yet
4 participants
@trentm

trentm commented Jul 20, 2015

This is with Komodo IDE, version 9.1.0, build 87337, platform macosx.

Repro:

  • switch to Vi keybindings
  • type 'V' to enter line selection mode
  • select down repeatedly with 'j'

When selection hits the bottom of the view port (actually the y-slop line), the editor view should scroll up.

The same problem exists when scrolling up.

@Naatan

This comment has been minimized.

Show comment
Hide comment
@Naatan

Naatan Jul 20, 2015

Member

I'll get our Vi guy to have a look at this. oh wait ..

Kidding aside, was able to easily reproduce this, will have a look.

Member

Naatan commented Jul 20, 2015

I'll get our Vi guy to have a look at this. oh wait ..

Kidding aside, was able to easily reproduce this, will have a look.

@Naatan Naatan added this to the 9.2.1 milestone Jul 20, 2015

@Naatan Naatan added the Type: Bug label Jul 20, 2015

@twhiteman

This comment has been minimized.

Show comment
Hide comment
@twhiteman

twhiteman Jul 20, 2015

Contributor

Probably needs a scimoz.scrollCaret(); after the updateVisualModeSelection() call:
https://github.com/Komodo/KomodoEdit/blob/master/src/chrome/komodo/content/keybindings/viKeyBinder.js#L804

Contributor

twhiteman commented Jul 20, 2015

Probably needs a scimoz.scrollCaret(); after the updateVisualModeSelection() call:
https://github.com/Komodo/KomodoEdit/blob/master/src/chrome/komodo/content/keybindings/viKeyBinder.js#L804

@Naatan Naatan modified the milestones: 9.2.1, 9.2.2 Aug 14, 2015

@mitchell-as mitchell-as self-assigned this Aug 14, 2015

@mitchell-as mitchell-as modified the milestones: 9.2.1, 9.2.2 Aug 14, 2015

mitchell-as added a commit that referenced this issue Aug 14, 2015

keybindings: vi: Ensure the caret is scrolled into view after moving …
…in visual mode - fixes #436

rn=

(integrated from master branch change 9.2.1-233-gb5f20b1 by Mitchell <mitchellb@activestate.com>)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment