New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential memory leak in file closing #627

Closed
Naatan opened this Issue Sep 26, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@Naatan
Member

Naatan commented Sep 26, 2015

  1. Check your current Komodo memory usage
  2. Open feature-core.ini (in the wix)
  3. Close it
  4. Repeat 2 and 3 10 times
  5. Check memory usage

Memory usage will have increased by about 10-20mb. It will potentially be bigger with larger files.

Let's try and narrow this down to Komodo or Scintilla first.

@Naatan

This comment has been minimized.

Member

Naatan commented Sep 28, 2015

Memory reports of before and after 2 days of use. Nothing stands out to me, memory usage seems to simply increase across the board.

memory-report1.txt
memory-report2.txt

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Oct 8, 2015

This is very likely Komodo and not Scintilla.

Initial Memory usage: 221MB
Usage after one cycle of open/close feature-core.ini: 231MB
Usage after another cycle: 225MB
And another: 243MB
And another: 236MB
And another: 247MB
And another: 259MB
And another: 256MB
And another: 254MB
And another: 255MB

As you can see, memory usage plateaus. Therefore Scintilla is being a good citizen when it comes to memory usage.

@mitchell-as mitchell-as assigned Naatan and unassigned mitchell-as Oct 8, 2015

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Oct 8, 2015

Perhaps we can try explicitly envoking the JS garbage collector on file close? I wouldn't be surprised if there are a lot of things left floating around.

@Naatan

This comment has been minimized.

Member

Naatan commented Oct 8, 2015

I have tried that, when Komodo starts it's at around 250MB memory usage for me, after about a day it is around 600MB (and usually stays around that point, the "leak" is not that bad) but clearing memory via about:memory has very little effect on that.

More concerning to me is that file opening and closing becomes much slower, which I think is related to this. Point being is that I believe fixing the memory issue will fix file opening/closing slowdowns.

@Naatan Naatan modified the milestones: 10.0, 9.3 Oct 21, 2015

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Apr 6, 2016

Are you still seeing this @Naatan ? Or has your profiling uncovered anything?

@Naatan

This comment has been minimized.

Member

Naatan commented Apr 7, 2016

Yep, still seeing this. It seems to increase pretty consistently for me, I cannot get it to "plateau".

None of the "Free Memory" tools in about:memory seem to reclaim this memory.

@Naatan Naatan closed this in c4bd7c1 Apr 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment