New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP CodeIntel does not inherit interface methods #751

Closed
garak opened this Issue Oct 21, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@garak

garak commented Oct 21, 2015

Use case: interface A inherits from interface B.
If I try to automcomplete a method of interface A, everything is fine (e.g. I got that method autocompleted).
Instead, if I try to autocomplete a method if interface B (that is also in A, of course, by inheritance), it's not autocompleted.

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Oct 21, 2015

Hi, I thought I understood where you were coming from, but when I tried to reproduce on my machine, I couldn't. Would you please post an example? I don't know much PHP. Thanks.

@garak

This comment has been minimized.

garak commented Oct 26, 2015

<?php

Interface A
{
    public function foo();
}

Interface B extends A
{
    public function bar();
}

class classB
{
    public function __construct(B $b)
    {
        $b->bar();  // this works, it's autocompleted and linked
        $b->foo();  // this should work, but it doesn't
    }
}

@mitchell-as mitchell-as added this to the 9.3.1 milestone Oct 26, 2015

@mitchell-as mitchell-as self-assigned this Oct 26, 2015

@Naatan Naatan modified the milestones: 9.3.1, 9.4 Nov 4, 2015

@Naatan Naatan modified the milestones: 9.3.2, 9.4 Nov 13, 2015

@Naatan

This comment has been minimized.

Member

Naatan commented Nov 13, 2015

Reopening this so that it's integrated to 9.3.2, please do not integrate until 9.3.1 is out the door.

@Naatan Naatan reopened this Nov 13, 2015

mitchell-as added a commit that referenced this issue Nov 19, 2015

fix: codeintel: PHP: Fixed interface method inheritence - fixes #751
rn=

(integrated from master branch change 9.2.1-690-g4a1a548 by Mitchell <mitchellb@activestate.com>)
@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Nov 19, 2015

Merged for 9.3.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment