New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KomodoIDE 9.3 spellcheck words in literal strings; shouldn't do that #827

Closed
roman02 opened this Issue Nov 7, 2015 · 7 comments

Comments

Projects
None yet
3 participants
@roman02

roman02 commented Nov 7, 2015

It underlines many tokens in my SQL statements. Shouldn't do that.

It also underlines things in commented out statements, e.g., it doesn't like dbh in this:

// $userId = $dbh->lastInsertId();

This is distracting.

@Naatan

This comment has been minimized.

Member

Naatan commented Nov 7, 2015

A comment is a comment, we cannot start interpreting those for "commented out code". You can disable spell checking if this annoys you.

As for SQL statements, can you give some sample code?

@roman02

This comment has been minimized.

roman02 commented Nov 7, 2015

Sure, please see the attached screenshot.

komodo - spellchecked sql statement

@Naatan

This comment has been minimized.

Member

Naatan commented Nov 7, 2015

@mitchell-as thoughts on this? Should we just disable spell check in strings or maybe we can be more intelligent as to what words qualify for spell checking (ie. don't spell check blocks (delimited by whitespace) that contain special characters).

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Nov 9, 2015

I can disable spell checking in SQL strings only. That might be for the best for this particular language.

I don't like the idea of trying to be intelligent because you might have "(parenthetical)" in an error message or GUI label or something that should be spell checked.

@Naatan

This comment has been minimized.

Member

Naatan commented Nov 9, 2015

I am fairly certain we do not interpret SQL strings in languages like PHP, they are just interpreted like regular strings.

How about we make it a pref? I can certainly see the use-case in wanting to use spell checking but also having a document with a lot of complex strings that cannot possibly be spell checked properly unless the spell checker is made a bit less "literal".

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Nov 9, 2015

Oh, I thought you meant the SQL language lexer. Yeah I suppose we can do a pref.

@mitchell-as mitchell-as added this to the 9.4 milestone Nov 9, 2015

@mitchell-as mitchell-as self-assigned this Nov 9, 2015

@Naatan Naatan modified the milestones: 9.4, 10.0 Nov 13, 2015

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Mar 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment