New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include field is ignored in the search dialog for projects #858

Closed
jsnjack opened this Issue Nov 13, 2015 · 9 comments

Comments

Projects
None yet
3 participants
@jsnjack

jsnjack commented Nov 13, 2015

Include field is ignored in the search dialog when field Where is project. I tried to start search only in js files by specifying it like *.js. If Where field is Files it works as expected, but if I change it to Project it just starts search in all files.

Komodo 9.3, linux

@Naatan

This comment has been minimized.

Member

Naatan commented Nov 13, 2015

Reproduced on Linux.

@Naatan Naatan added the Type: Bug label Nov 13, 2015

@Naatan Naatan added this to the 9.3.2 milestone Nov 13, 2015

@Naatan Naatan self-assigned this Nov 13, 2015

@Naatan Naatan modified the milestones: 9.3.2, 9.3.3 Dec 9, 2015

@jsnjack

This comment has been minimized.

jsnjack commented May 17, 2016

@Naatan I have just checked and the same problem exists in komodo 10. I guess there will be no 9.3.3 release?

@Naatan Naatan modified the milestones: 10.0.1, 9.3.3 May 17, 2016

@Naatan

This comment has been minimized.

Member

Naatan commented May 17, 2016

Unlikely, we have a 9.3.3 nightly but I don't see a full release happening at this point.

@jsnjack

This comment has been minimized.

jsnjack commented May 17, 2016

Thanks! Looking forward to see that issue fixed (opening other editor just for search operation is annoying :/ )

@Naatan

This comment has been minimized.

Member

Naatan commented Jun 8, 2016

@mitchell-as was this not implemented at all for projects?

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jun 8, 2016

That's right. Komodo 8 did not have this.

@Naatan

This comment has been minimized.

Member

Naatan commented Jun 8, 2016

Nor Komodo 9, I assume?

I'll create a new enhancement request for this to be added. I've found myself often wanting it in the project context.

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jun 8, 2016

No. I noted in my commit message that this "include" field was accidentally introduced when the find dialog got integrated into a pane (as opposed to being a separate dialog).

@Naatan

This comment has been minimized.

Member

Naatan commented Jun 8, 2016

Gotcha, thanks @mitchell-as :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment