New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Komodo 8 and 9 Codeinteligence UpperLetters bug. #870

Closed
MironMironMiron opened this Issue Nov 16, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@MironMironMiron

MironMironMiron commented Nov 16, 2015

i use comodoEdit
codeinteligence crash and down work when file name contens upper letters. or path.

example. i create class in php: newClass.php

when i save file: calling method do_scan_document
in codeintel2/oop/driver.py

in AppData\Local\ActiveState\KomodoEdit\9.3\codeintel\db\php
creates new blob file:
scope ilk="blob" lang="PHP" name="newclass.php" src="s:/domains/class/newclass.php"
scope ilk="class" line="3" lineend="5" name="newClass2"
how you see src is not s:/domains/class/newClass.php it contents lower case.

then running scann all dirs script: and create new blob file. (IN DB We HAWE 2 blob files)
scope ilk="blob" lang="PHP" name="newClass.php" src="s:/domains/class/newClass.php"
scope ilk="class" line="3" lineend="5" name="newClass2"
second file src hawe upper letters.

but when i modific class and add some function this function add in firs blob file.
scope ilk="blob" lang="PHP" name="newclass2.php" src="s:/domains/class/newclass.php"
scope ilk="class" line="3" lineend="8" name="newClass2"
scope attributes="public" ilk="function" line="4" lineend="7" name="last" signature="last()"

and when i in editor try call my new function -> newClass->.... i dont see my new function.
because in db exist two blob index to one file. (function i call in other file)

this bag was in komodo8. and left in comodo9.
Plese fix it.

codeinteligence in all uses who create files width uppler/lowwer letters not work. !!!!!!!

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Nov 16, 2015

Hi, I'm having difficulty understanding how this issue is being caused for you. Could you post the contents of both of your files so I can try to reproduce this? I'm also not sure how you get from "newClass.php" to a broken state -- the instructions are not clear to me.

Please keep in mind that Windows filenames are NOT case-sensitive. so if you are trying to edit a "newClass.php" file in the same directory as a "NewClass.php" file, you are actually editing the same file. That may be causing codeintel some problems, but again, I'm not sure exactly what you're trying to do.

Thanks for your patience.

@MironMironMiron

This comment has been minimized.

MironMironMiron commented Nov 18, 2015

hi problem not in windows case-sensitive.

when directories or files have upper lowwer leters in codeinteligence db creates to may .blob files
and codeingeligence dont work. when i modifi one class. my changes dont see in other classes.

i add dome wideo where i show what is wrong and what is problem.

https://www.dropbox.com/s/gp0vhbz4aic60yr/codeinteligence_bug.mp4?dl=0
()

you can try this self.

please fix this. all who writes directories and file names witch uppler and lowwer letters cant use
codeinteligence correctly.

@mitchell-as mitchell-as added this to the 9.3.2 milestone Nov 18, 2015

@mitchell-as mitchell-as self-assigned this Nov 18, 2015

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Nov 18, 2015

Thank you for taking the time to diligently and clearly show the problem! We will look into this.

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Nov 23, 2015

Note to self: this is not exclusive to PHP. I also reproduced using Python. Therefore it does not appear to happen in the language CILErs.

mitchell-as added a commit that referenced this issue Nov 24, 2015

fix: codeintel: Do not create extra, unnecessary CIX files on Windows -
fixes #870

Be consistent with file case. Otherwise codeintel gets confused with two
nearly identical CIX files.

rn=

(integrated from master branch change 9.2.1-701-g28fe322 by mitchell-as <mitchellb@activestate.com>)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment