New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to control search panels with tab key #883

Closed
jamadam opened this Issue Nov 18, 2015 · 13 comments

Comments

Projects
None yet
5 participants
@jamadam

jamadam commented Nov 18, 2015

  1. open "Edit" > "Replace" then "Find:" area is forcused(as expected).
  2. Hit tab key and then "Where:" area is focused but can't distinguish visibly.

The focus state of icons such as "Match Cases" is also indistinguishable.

MacOSX Yosemite 10.10.5
Komodo Edit, version 9.3.0, build 16396, platform macosx. Built on Fri Oct 30 20:10:43 2015.

@landy2005

This comment has been minimized.

landy2005 commented Nov 18, 2015

I also confirm this issue..
Icons "Match Cases" visually quite indistinguishable.

@Naatan Naatan added this to the 9.3.2 milestone Nov 18, 2015

@Naatan Naatan self-assigned this Nov 18, 2015

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Nov 18, 2015

Just to clarify, the Tab key isn't an issues. It's the inability to see where you've tabbed to? Pressing tab goes where you expect it to go right?

@jamadam

This comment has been minimized.

jamadam commented Nov 19, 2015

@cgchoffman I guess tab key works. Visibility is the issue here.
Since I can't see where is the focus, I'm not sure the tab-order is as expected.

@testworksau

This comment has been minimized.

testworksau commented Nov 19, 2015

Same issue on Windows.

As a side note, when you tab all the way back around again, the find window closes itself. It's a bit annoying, particularly because reopening the find dialog will clear the test you may have just entered in.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Nov 19, 2015

As a side note, when you tab all the way back around again, the find window closes itself.

@testworksau that's a different issue. You can file a new issue for that.

@jamadam I think this needs to be narrowed down a bit. The issue is that you can't tell when you're on the Icons right? Note on OSX you can't Tab through buttons or Drop-downs (that eliminates the icons for replace, match case, etc.). This means that Tabbing does the following (on OSX) Find > Replace> Includes.

@testworksau

This comment has been minimized.

testworksau commented Nov 19, 2015

@cgchoffman done - see issue 888

@jamadam

This comment has been minimized.

jamadam commented Nov 20, 2015

@cgchoffman Ah, you reminds me of tab setting in OSX preference which I set to "All controls".

It's in OSX's System Preference > Keyboard > Shortcut > Mission Control. You can also toggle it with Control + F7 key bind. If the setting is "Only text box and list", the default one, there isn't any issue. I'm sorry not to share the information.

With my setting, the focus seems to move in following order and the visibility issue is on icons, buttons, drop-downs.

  • Find:
  • Replace:
  • Where:
  • Mark All button
  • Replace All button
  • include:
  • ?
  • case sensitivity icon
  • W icon
  • multiline icon
  • Regular Expression icon
  • and so on..
@Naatan

This comment has been minimized.

Member

Naatan commented Nov 20, 2015

Ah, you reminds me of tab setting in OSX preference which I set to "All controls".

Oh wow, I was not aware this setting existed. Thanks for sharing!

The focus does seem to shift oddly when using the "Current Document" scope.

@cgchoffman I think your workaround may be the cause here, probably safer if we are more explicit with the tabindex.

@Naatan Naatan assigned cgchoffman and Naatan and unassigned Naatan and cgchoffman Nov 20, 2015

@Naatan

This comment has been minimized.

Member

Naatan commented Nov 20, 2015

Err actually this should be a separate issue, it has nothing to do with focus being hard to distinguish.

@jamadam can you please open a new bug.

@jamadam

This comment has been minimized.

jamadam commented Nov 25, 2015

@Naatan Well, I don't get what I suppose to open a new issue for. My only point is the appearance of focus and not sure so far the tab-order is appropriate or not.

I also checked the komodo Edit v8.5 behavior depending on OSX keyboard setting and there is no major defferences between the versions except the appearance.

@Naatan

This comment has been minimized.

Member

Naatan commented Nov 25, 2015

@jamadam the issue we'll track here is the focus not being distinguishable, you raised another issue which is that the focus is not shifting logically, this would need to be tracked in its own bug report.

Generally we ask people to open a bug rather than doing it ourselves because when we do it ourselves the original reporter of the issue is not CC'ed on future updates, and we may also be lacking some detail that the original reporter could give.

@jamadam

This comment has been minimized.

jamadam commented Nov 25, 2015

@Naatan Sorry, It has something to do with my English literacy but I have never intended to report "the focus is not shifting logically." and not even understand what it means.

I also don't get what you mean by

The focus does seem to shift oddly when using the "Current Document" scope.

@Naatan Naatan added Type: Bug and removed Type: Enhancement labels Nov 26, 2015

@Naatan

This comment has been minimized.

Member

Naatan commented Nov 26, 2015

Oh ok, no worries then :) You unintentionally raised another issue.

@Naatan Naatan closed this in ec3dd03 Dec 3, 2015

Naatan added a commit that referenced this issue Dec 3, 2015

UI: Highlight focused elements in the HUD - fixes #883
rn=

(integrated from master branch change 9.2.1-719-g4589ae1 by Nathan Rijksen <n.rijksen@gmail.com>)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment