New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap: buffer scrolls up when indenting near the end of a large file. #900

Closed
gabrielfojo opened this Issue Nov 24, 2015 · 10 comments

Comments

Projects
None yet
6 participants
@gabrielfojo

gabrielfojo commented Nov 24, 2015

This only happen when the document goes beyond the height of the window, indenting more than one line together send me Upwards to page 1 -
---- now i can not reproduce it- it happen sometimes -

Komodo Edit, version 8.5.4, build 14424, platform linux-x86_64. Built on Thu Aug

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Nov 24, 2015

Please try the latest Komodo Edit and see if the issue persists: http://downloads.activestate.com/Komodo/releases/9.3.1/

If it does, please provide more details. Exactly steps taken.

  • I created a PHP doc
  • added lines to the doc until it was longer than the view port
  • selected multiple lines
  • pressed tab
  • lines indented, nothing else happened.

I can't reproduce this with the information you've provided.

@babobski

This comment has been minimized.

Contributor

babobski commented Nov 26, 2015

@cgchoffman i can reproduce the problem, this bug appears when working with some larger files.
When you indent or de-indent the position is off.

Made a screencast to clarify the issue.

This issue also occurs sometimes while pasting in komodo.
I'm having this bug for a long time in komodo but wasn't annoying enough for me to report.

Some more info
i don't have font-zooming enabled
Also tested it in the default skin same issue here

[2015-11-26 18:33:59,572] [INFO] Startup: Welcome to Komodo Edit 9.3.1 build 16421 (platform win32-x86, running on Windows post2012Server version 6.3.9600) [2015-11-26 18:33:59,572] [INFO] Startup: C:\Program Files (x86)\ActiveState Komodo Edit 9 nightly\lib\mozilla\komodo.exe built on Thu Nov 12 11:30:46 2015

windows 10

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Nov 26, 2015

Ahh, it's the minimap. Thanks a lot for the video @babobski. Super helpful.

  • enable minimap
  • open file that is longer than the window height
  • select a block of text
  • hit tab

Expect: just some nice tabbing
Actual: Nice tabbing AND the buffer scrolls up

This issue also occurs sometimes while pasting in komodo.

This sounds really familiar. I think we're tracking that issue in another ticket. I'm going to have a look for it.

@cgchoffman cgchoffman added this to the 9.3.2 milestone Nov 26, 2015

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Nov 26, 2015

It's #901 that I was thinking of but I don't think it's related though similar symptoms.

@babobski

This comment has been minimized.

Contributor

babobski commented Nov 26, 2015

Ahh, it's the minimap.

Did some more testing, but it's definitely the minimap.
Had the same problems with the addons i wrote.
With the Beautify js addon when you re flow a part of code on larger files, it's getting jumpy like as in the screencast.
When i turn of the mini map this behavior disappears. Same for the Less Compiler you can compile a selection, on larger files, same issue here, and turning of the mini map resolves this behavior.

@cgchoffman cgchoffman changed the title from indenting to Minimap: buffer scrolls up when indenting near the end of a large file. Nov 26, 2015

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Nov 26, 2015

Thanks @babobski. I've updated the bug description to be more clear.

@babobski

This comment has been minimized.

Contributor

babobski commented Nov 26, 2015

ok 👍

@gabrielfojo

This comment has been minimized.

gabrielfojo commented Nov 26, 2015

thanks @babobski , the issue was messing with my zen state ;)

@Naatan Naatan modified the milestones: 9.3.2, 9.3.3 Dec 9, 2015

@Naatan Naatan modified the milestones: 9.3.3, Perpetual May 18, 2016

@cdcmicro

This comment has been minimized.

cdcmicro commented Oct 13, 2016

Wow. I was all ready to write this up (again). Nice the reporting work is already done.

I confirm the behavior in IDE 10 for block indent (tab), block dedent (shift+tab), and paste (shift+insert or ctrl+v). Any chance it could get assigned/fixed sometime soon? Maybe along with #2080 ?

Komodo IDE, version 10.1.1, build 89474, platform win32-x86.
Built on Thu Sep 01 14:27:01 2016.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Oct 13, 2016

Thanks for pinging this. I've updated the ticket.

Naatan added a commit that referenced this issue Nov 8, 2016

fix: editor: Change indentation on a per-line basis instead of all at…
… once - fixes #900

There are side-effects to replacing entire blocks of text, including undesired
scrolling.

rn=

(integrated from the KomodoIDE master branch change 9e00bdc by Mitchell <mitchellb@activestate.com>)

Komodo/KomodoIDE@9e00bdc

mitchell-as added a commit that referenced this issue Nov 28, 2016

fix: editor: Fixed regression in selection position when changing ind…
…entation - fixes #2180

Introduced in fix to #900.

rn=

(integrated from the KomodoIDE master branch change 5ce466e by Mitchell <mitchellb@activestate.com>)

Komodo/KomodoIDE@5ce466e

mitchell-as added a commit that referenced this issue Nov 28, 2016

fix: editor: Fixed regression in selection position when changing ind…
…entation - fixes #2180

Introduced in fix to #900.

rn=

(integrated from the KomodoIDE master branch change 5ce466e by Mitchell <mitchellb@activestate.com>)

Komodo/KomodoIDE@5ce466e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment