New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated EditorConfig ignores .editorconfig #908

Closed
MichaLueth opened this Issue Nov 26, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@MichaLueth

MichaLueth commented Nov 26, 2015

I used EditorConfig as an add-on until KE 9.2 that worked very well. Now KE ignores everything set in .editorconfig file.

I run KE on 2 different Linux machines (1 VM) and the issue is present on both. I've tried to re-install KE -- EC still doesn't work.

Komodo Edit, version 9.3.0, build 16396, platform linux-x86_64. Built on Fri Oct 30 20:10:33 2015.

@Naatan

This comment has been minimized.

Member

Naatan commented Nov 26, 2015

Please uninstall the addon, Komodo has built-in support for editorconfig now.

@MichaLueth

This comment has been minimized.

MichaLueth commented Nov 26, 2015

Yes, I know that and I don't use EC add-on. That's why I wrote here "Integrated EditorConfig" -- I mean the built-in support for EC.

@Naatan

This comment has been minimized.

Member

Naatan commented Nov 26, 2015

Try this:

Hit Help > Troubleshooting > Reset File Preferences

EditorConfig used to override file level prefs, now it only enforces them softly. Meaning that it does not override a pref that was explicitly set on a file. By using the action I explained you reset all your file level prefs.

@MichaLueth

This comment has been minimized.

MichaLueth commented Nov 26, 2015

Sorry, no desired result.

@Naatan

This comment has been minimized.

Member

Naatan commented Nov 26, 2015

I'll try to reproduce this when I have some time.

@Naatan Naatan self-assigned this Nov 26, 2015

@Naatan Naatan added this to the 9.3.2 milestone Nov 26, 2015

@MichaLueth

This comment has been minimized.

MichaLueth commented Nov 26, 2015

No problem

@Naatan Naatan added Type: Bug and removed Pending: Internal labels Dec 3, 2015

@Naatan

This comment has been minimized.

Member

Naatan commented Dec 3, 2015

Reproduced, I'll have to revert our change that was meant to make editorconfig less forceful as there is currently no proper way to address this that wouldn't take a lot of work.

EditorConfig users will just have to use EditorConfig to make their changes to prefs that they define in their .editorconfig file. You cannot use both .editorconfig and the Komodo prefs, the former will always win.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment