New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Codeintel stops processing on unknown blocks #938

Closed
Naatan opened this Issue Dec 7, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@Naatan
Member

Naatan commented Dec 7, 2015

Take the following example:

@import url("chrome://komodo/skin/global/icons/variables.less");

@font-face {
    font-family: 'icomoon';
    src:url('chrome://komodo/skin/global/icons/fonts/icomoon.eot?ajp3sn');
    src:url('chrome://komodo/skin/global/icons/fonts/icomoon.eot?ajp3sn#iefix') format('embedded-opentype'),
        url('chrome://komodo/skin/global/icons/fonts/icomoon.ttf?ajp3sn') format('truetype'),
        url('chrome://komodo/skin/global/icons/fonts/icomoon.woff?ajp3sn') format('woff'),
        url('chrome://komodo/skin/global/icons/fonts/icomoon.svg?ajp3sn#icomoon') format('svg');
    font-weight: normal;
    font-style: normal;
}

.icon, [class^="icon-"], [class*=" icon-"], [class$="-icon"], [class*="-icon "] {
    /* use !important to prevent issues with browser extensions that change fonts */
    font-family: 'icomoon' !important;
    speak: none;
    font-style: normal;
    font-weight: normal;
    font-variant: normal;
    text-transform: none;
    line-height: 1;

    /* Better Font Rendering =========== */
    -webkit-font-smoothing: antialiased;
    -moz-osx-font-smoothing: grayscale;
}

.icon-markdown {
    &:before {
        content: @icon-markdown;
    }
}

As per Mitchell's feedback it appears the codeintel parser fails on the @font-face block. Of course ideally it should be able to parse @font-face, but better still - it should not stop parsing if it comes across a block that it does not recognize.

Please re-target for 10 if this ends up being a big code change.

@Naatan Naatan added the Type: Bug label Dec 7, 2015

@Naatan Naatan modified the milestones: 9.3.2, 9.3.3 Dec 7, 2015

mitchell-as added a commit that referenced this issue Jan 25, 2016

fix: codeintel: CSS: Fixed failure to detect selectors in some instan…
…ces - fixes #938

rn=

(integrated from master branch change 9.2.1-793-gd837c2e by Mitchell <mitchellb@activestate.com>)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment