New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a Komodo language extension fails when name has more than one space #983

Closed
xcash opened this Issue Jan 5, 2016 · 7 comments

Comments

Projects
None yet
4 participants
@xcash

xcash commented Jan 5, 2016

Just created a new language using Projects -> New from template -> Create Komodo Language

Filled everything. HTML based language.
Build and Install and it complains "This package is not compatible"
I'm using 9.3.2

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jan 5, 2016

Will you please post the contents of your log? Help > Troubleshooting > View Log File.

For the record I cannot reproduce this, but I have a clean profile.

@xcash

This comment has been minimized.

xcash commented Jan 5, 2016

Sure. I forgot to mention I'm on Linux ubuntu 15.10.

Here's the log:

[2016-01-05 15:17:53,818] [WARNING] views: Inconsistent view count in view_closed event
[2016-01-05 15:17:53,862] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'collab_remote_change'
[2016-01-05 15:17:53,863] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'spelling_error'
[2016-01-05 15:17:53,864] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'collab_local_change'
[2016-01-05 15:17:53,864] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'collab_remote_cursor_4'
[2016-01-05 15:17:53,864] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'collab_remote_cursor_5'
[2016-01-05 15:17:53,864] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'collab_remote_cursor_2'
[2016-01-05 15:17:53,864] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'collab_remote_cursor_3'
[2016-01-05 15:17:53,866] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'collab_remote_cursor_1'
[2016-01-05 15:17:53,972] [WARNING] views: Inconsistent view count in view_opened event
[2016-01-05 15:17:59,979] [ERROR] console-logger: not well-formed (0) in jar:file:///home/x-cash/Projects/others/komodo_jinja_language/jinja_language-0.1-ko.xpi!/install.rdf:10
Traceback (most recent call last):
  File "jar:file:///home/x-cash/Projects/others/komodo_jinja_language/jinja_language-0.1-ko.xpi!/install.rdf", line 10, in 

[2016-01-05 15:18:02,857] [WARNING] console-logger: Error in parsing value for 'left'.  Declaration dropped. (1) in chrome://console/content/views/console.html:0
[2016-01-05 15:18:04,529] [WARNING] notify: Notification panel has already been removed, callback is likely called twice
[2016-01-05 15:18:16,677] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'collab_remote_change'
[2016-01-05 15:18:16,678] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'spelling_error'
[2016-01-05 15:18:16,678] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'collab_local_change'
[2016-01-05 15:18:16,678] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'collab_remote_cursor_4'
[2016-01-05 15:18:16,679] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'collab_remote_cursor_5'
[2016-01-05 15:18:16,679] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'collab_remote_cursor_2'
[2016-01-05 15:18:16,679] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'collab_remote_cursor_3'
[2016-01-05 15:18:16,680] [WARNING] koScintillaSchemeService: applyScheme:: no indicator for name 'collab_remote_cursor_1'

I just noted the jar error is not visible in the building output tab.
i really didn't modified anything yet in the language files but I can share the full project if you need it.

Thank you :)

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jan 5, 2016

Ah, it looks like underscores are not allowed in the name. Please try creating a new language with '-' instead of '_' and see if that helps.

@xcash

This comment has been minimized.

xcash commented Jan 5, 2016

Well it's the wizard that converts spaces and dashes to underscores.. and it looks weirder than that. Seems it accepts at most one underscore. :D
I tried with only one and it worked. :) Thanks a lot but this should be fixed, at least with a more evident error showing up.
And keep up with the amazing work you're doing on Komodo! :)

@Naatan Naatan changed the title from Creating a Komodo language extension doesn't build and install out of the box to Creating a Komodo language extension fails when name has more than one space Jan 5, 2016

@Naatan Naatan added the Type: Bug label Jan 5, 2016

@Naatan Naatan added this to the 9.3.3 milestone Jan 5, 2016

@Naatan

This comment has been minimized.

Member

Naatan commented Jan 5, 2016

My bet is on the dev who implemented this not putting a /g flag on the replace.

mitchell-as added a commit that referenced this issue Jan 25, 2016

fix: koextgen: Ensure extension name is valid for user-defined langua…
…ges - fixes #983

rn=

(integrated from master branch change 9.2.1-796-g3a28913 by Mitchell <mitchellb@activestate.com>)
@Naatan

This comment has been minimized.

Member

Naatan commented Jan 25, 2016

Points for me!

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Jan 27, 2016

gave 5 points for Nathan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment