Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DB path to ctx instead of static var. #323

Closed
artemii235 opened this issue Mar 5, 2019 · 3 comments
Closed

Move DB path to ctx instead of static var. #323

artemii235 opened this issue Mar 5, 2019 · 3 comments
Assignees
Projects

Comments

@artemii235
Copy link
Member

No description provided.

@ArtemGr
Copy link

ArtemGr commented Apr 4, 2019

@artemii235 , "dbdir" is a config parameter and we can use it directly from conf (via ctx.conf), with a helper ctx method if needed for convenience. Can you please clarify whether there is a reason to duplicate it in a ctx field? Or would the conf-based solution suffice?

@artemii235
Copy link
Member Author

artemii235 commented Apr 4, 2019

@ArtemGr Hi, conf-based solution is fine, I just didn't provide the full description. There's a GLOBAL_DBDIR var that is still used by C-code, would be nice to get rid of it, however it only affects some rare test cases when we want to run multiple MM2 instances on same thread. So this is low priority task.

@ArtemGr
Copy link

ArtemGr commented Apr 4, 2019

Copy!

@ArtemGr ArtemGr self-assigned this Apr 10, 2019
@ArtemGr ArtemGr added this to Iteration in MM 2.0 via automation Apr 10, 2019
@ArtemGr ArtemGr moved this from Iteration to In progress in MM 2.0 Apr 10, 2019
@ArtemGr ArtemGr moved this from In progress to Done in MM 2.0 Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MM 2.0
  
Done
Development

No branches or pull requests

2 participants