Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portability WIP #517

Merged
merged 4 commits into from Aug 12, 2019

Conversation

@ArtemGr
Copy link
Collaborator

commented Aug 12, 2019

@artemii235 , I'm trying to use async/await futures for the portable version of CORE.spawn,
for reasons of compatibility with the future of futures and code simplification.
As a part of it I changed some of the Electrum code in rpc_clients to use the async/await spawn.
Would like you to take a look, maybe you'll spot something I've missed in the logic during refactorings.

ArtemGr added 3 commits Aug 11, 2019
Allow for coarse concurrency
`delta < 0.3` fails on MacOS, the thread scheduling is probably more coarse-grained there
@artemii235
Copy link
Collaborator

left a comment

@ArtemGr Thanks for PR! I've left 1 comment regarding time subtraction, looking forward to your response 🙂

@ArtemGr ArtemGr force-pushed the mm2-wip branch from 64fd377 to 0f52694 Aug 12, 2019

Use a signed time delta
In order to avoid the integer underflows when clock shifts.
@artemii235
Copy link
Collaborator

left a comment

🔥

@ArtemGr ArtemGr merged commit b2aab61 into mm2 Aug 12, 2019

1 check passed

atomicDEX-API #20190812.10 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.