Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SameDiff execution, TF and memory management overhaul #10

Merged
merged 76 commits into from Oct 23, 2019
Merged

Conversation

@AlexDBlack
Copy link
Member

AlexDBlack commented Oct 23, 2019

Fairly major overhaul to:

  • SameDiff graph execution
  • SameDiff training internals execution
    • Including in-line updating (enabled reduced memory)
  • TensorFlow import
  • SameDiff memory management
    • Peak memory requirements significantly reduced
    • No reliance on garbage collection

Improved maintainability, significantly reduced memory for execution, and more suitable for translation to C++.

Another PR will follow this one later, to add:

  • Memory cache (improved performance at the expense of slightly increased memory use)
  • DL4J workspace integration for "SameDiff in DL4J" layers

In both cases, they will build on the existing APIs added in this PR.

Also removes the non-functional OnnxGraphMapper for now, pending rewrite.

Also fixes some unrelated issues.

Fixes: eclipse#8237
Fixes: eclipse#8286
Fixes: eclipse#8275

AlexDBlack added 30 commits Oct 5, 2019
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
…tion internals to not rely on cached op outputs

Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
AlexDBlack added 24 commits Oct 19, 2019
Signed-off-by: AlexDBlack <blacka101@gmail.com>
…ted loops/frames

Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
…rray reuse

Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
…rt of all TF import tests

Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
@AlexDBlack AlexDBlack merged commit 3f0b4a2 into master Oct 23, 2019
@AlexDBlack AlexDBlack deleted the ab_sd_exec branch Oct 23, 2019
raver119 added a commit that referenced this pull request Oct 26, 2019
Shugeo fake quant2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.