Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for empty streams for NativeImageLoader + test #121

Merged
merged 1 commit into from Dec 10, 2019

Conversation

@AlexDBlack
Copy link
Member

AlexDBlack commented Dec 10, 2019

Fixes: eclipse#8515

Signed-off-by: AlexDBlack <blacka101@gmail.com>
@AlexDBlack AlexDBlack merged commit 4920f22 into master Dec 10, 2019
1 check was pending
1 check was pending
continuous-integration/jenkins/pr-head This commit is being built
Details
@AlexDBlack AlexDBlack deleted the ab_nil_emptystream branch Dec 10, 2019
@SubshellDaniel

This comment has been minimized.

Copy link

SubshellDaniel commented Dec 10, 2019

The tests need fail() in the try blocks! Else they won't fail but silently do nothing if no exceptions is thrown. Or instead an expected result should be compared like an empty Mat for an empty file, if that is OK.

@AlexDBlack

This comment has been minimized.

Copy link
Member Author

AlexDBlack commented Dec 10, 2019

@SubshellDaniel thanks, good catch.
I have written plenty of tests with exactly that try/fail/catch pattern, I just forgot it this time.
I can confirm they do throw exceptions though in all cases tested for this already, and will add the fail to prevent regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.