Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SameDiff memory reuse memory manager (array cache) #39

Merged
merged 9 commits into from Nov 12, 2019

Conversation

@AlexDBlack
Copy link
Member

AlexDBlack commented Nov 9, 2019

Fixes: eclipse#8328

Benchmarking shows a non-negligible improvement in performance, especially on CUDA.

AlexDBlack added 9 commits Nov 9, 2019
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Signed-off-by: AlexDBlack <blacka101@gmail.com>
@AlexDBlack AlexDBlack marked this pull request as ready for review Nov 12, 2019
@AlexDBlack AlexDBlack merged commit 18c01f5 into master Nov 12, 2019
@AlexDBlack AlexDBlack deleted the ab_samediff_memcache branch Nov 12, 2019
AlexDBlack pushed a commit that referenced this pull request Nov 16, 2019
* [WIP] Fix compilation after nd4j changes (#37)

* Fix compilation.

* Some tests fixed

* Disable tests temporarily.

* Restored test

* Tests restored.

* Test restored.

* [WIP] perf tests (#40)

* special maxpool test

Signed-off-by: raver119 <raver119@gmail.com>

* special maxpool test

Signed-off-by: raver119 <raver119@gmail.com>

* Shyrma bnorm bp (#41)

Batchnorm backprop mkldnn

* Add SameDiff memory reuse memory manager (array cache) (#39)

* Attention op comments

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* ArrayCacheMemoryMgr - first pass

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Tweak array cache for use with SameDiff identity arrays

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* ArrayCacheMemoryMgr javadoc and properly get max memory

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* LRU cache policy + add tests

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Fixes

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Resize arrays internally if required for ArrayCacheMemoryMgr

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Test improvement

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Small polish

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* SameDiff op runtime benchmarking listener (#42)

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* INLINE_LOOPS for windows

Signed-off-by: raver119 <raver119@gmail.com>

* [WIP] ThreadPool (#8)

This PR removes OpenMP use in 95% of cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.