Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ByteBuffer fix #59

Merged
merged 1 commit into from Nov 20, 2019
Merged

ByteBuffer fix #59

merged 1 commit into from Nov 20, 2019

Conversation

@raver119
Copy link

raver119 commented Nov 19, 2019

This PR fixes couple of issues related to Java9+ and Java8 differences in ByteBuffer implementation

Signed-off-by: raver119 <raver119@gmail.com>
@raver119 raver119 requested a review from AlexDBlack Nov 19, 2019
Copy link
Member

AlexDBlack left a comment

Haven't tested, LGTM based on the description of this issue.
Only thought here is to add a comment so nobody removes it in the future - it'll probably look like an unnecessary cast to IDE...

@raver119 raver119 merged commit 3f38900 into master Nov 20, 2019
@raver119 raver119 deleted the r119_nio_buffer branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.