Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Create and small fix #67

Merged
merged 2 commits into from Nov 21, 2019
Merged

[WIP] Create and small fix #67

merged 2 commits into from Nov 21, 2019

Conversation

@raver119
Copy link

raver119 commented Nov 21, 2019

This PR:

  • adds Create op and its mapping for TF import
  • fixes non_max_suppression issue with empty inputs
raver119 added 2 commits Nov 21, 2019
- skip exec for empty inputs for non_max_suppression
- EmptyHandling idea

Signed-off-by: raver119 <raver119@gmail.com>
Signed-off-by: raver119 <raver119@gmail.com>
@raver119 raver119 requested a review from AlexDBlack Nov 21, 2019
Copy link
Member

AlexDBlack left a comment

So, we just override emptyHandling() method in each op where needed?
Sure, LGTM 👍

@raver119

This comment has been minimized.

Copy link
Author

raver119 commented Nov 21, 2019

We don't do that just yet, but it might be something like that. This PR just introduces basic enum + method + fix for op that crashes right now on master. Don't want to block everyone till we do proper handling for everything.

@raver119 raver119 merged commit 83cb0d9 into master Nov 21, 2019
@raver119 raver119 deleted the r119_few_more_fixes branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.