Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8415, BERT iterator inference #71

Merged
merged 3 commits into from Nov 22, 2019
Merged

Fixes #8415, BERT iterator inference #71

merged 3 commits into from Nov 22, 2019

Conversation

@eraly
Copy link

eraly commented Nov 22, 2019

Signed-off-by: eraly susan.eraly@gmail.com

What changes were proposed in this pull request?

Fixes eclipse#8415

How was this patch tested?

Added to unit tests. Tests pass

Quick checklist

The following checklist helps ensure your PR is complete:

  • Eclipse Contributor Agreement signed, and signed commits - see IP Requirements page for details
  • Reviewed the Contributing Guidelines and followed the steps within.
  • Created tests for any significant new code additions.
  • Relevant tests for your changes are passing.
Signed-off-by: eraly <susan.eraly@gmail.com>
@@ -341,6 +385,16 @@ public MultiDataSet next(int num) {
return tokens;
}


This comment has been minimized.

Copy link
@eraly

eraly Nov 22, 2019

Author

Not really thrilled about this. But I couldn't think of another to be able to reuse code for inference.

Signed-off-by: eraly <susan.eraly@gmail.com>
Copy link
Member

AlexDBlack left a comment

couple of things to add:
Copyright (c) 2019 Konduit K.K. under skymind copyright (line 3)

And a brief inference example in javadoc, around line 81

otherwise LGTM 👍

Signed-off-by: eraly <susan.eraly@gmail.com>
@eraly

This comment has been minimized.

Copy link
Author

eraly commented Nov 22, 2019

Done!

@AlexDBlack AlexDBlack merged commit 823bd0f into master Nov 22, 2019
@AlexDBlack AlexDBlack deleted the eraly branch Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.