Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shyrma scatter #84

Merged
merged 6 commits into from Nov 26, 2019
Merged

Shyrma scatter #84

merged 6 commits into from Nov 26, 2019

Conversation

@shyrma
Copy link

shyrma commented Nov 26, 2019

  • add fast routines for indices cheeking in scatter and gather ops (both cuda and cpu)
  • improve performance of scatter ops for 1D case (cuda)
@shyrma shyrma requested a review from raver119 Nov 26, 2019
Copy link

raver119 left a comment

LGTM, but some minor polishing required.

Plus, it would be awesome to add couple of tests that actually have bad indices passed into gather/scatter, just to see validation actually works.

Signed-off-by: Yurii <iuriish@yahoo.com>
@raver119 raver119 merged commit a8dd671 into master Nov 26, 2019
1 check failed
1 check failed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
@raver119 raver119 deleted the shyrma_scatter branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.