Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shyrma adjust #98

Merged
merged 13 commits into from Dec 3, 2019
Merged

Shyrma adjust #98

merged 13 commits into from Dec 3, 2019

Conversation

@shyrma
Copy link

shyrma commented Dec 2, 2019

  • add possibility of passing scalar-array as input parameter for scale factor in adjust hue/contrast/saturation ops
  • correct typo in function which calculates regularized incomplete beta integral
  • implement diGamma op
  • make polyGamma function to return nan when input order has float type
shyrma added 9 commits Nov 28, 2019
…e factor in adjust hue/contrast/saturation ops

- correct typo in function which calculates regularized incomplete beta integral

Signed-off-by: Yurii <iuriish@yahoo.com>
Signed-off-by: Yurii <iuriish@yahoo.com>
Signed-off-by: Yurii <iuriish@yahoo.com>
Signed-off-by: Yurii <iuriish@yahoo.com>
Signed-off-by: Yurii <iuriish@yahoo.com>
Signed-off-by: Yurii <iuriish@yahoo.com>
Signed-off-by: Yurii <iuriish@yahoo.com>
Signed-off-by: Yurii <iuriish@yahoo.com>

# Conflicts:
#	libnd4j/tests_cpu/layers_tests/DeclarableOpsTests3.cpp
…s been merged

Signed-off-by: Yurii <iuriish@yahoo.com>
@shyrma shyrma requested a review from raver119 Dec 2, 2019
shyrma added 3 commits Dec 2, 2019
Signed-off-by: Yurii <iuriish@yahoo.com>
Signed-off-by: Yurii <iuriish@yahoo.com>
Signed-off-by: Yurii <iuriish@yahoo.com>

# Conflicts:
#	libnd4j/include/ops/declarable/generic/parity_ops/adjust_contrast.cpp
#	libnd4j/include/ops/declarable/generic/parity_ops/adjust_saturation.cpp
Copy link

raver119 left a comment

LGTM, but empty check should be restored before merge.


// just skip op if input is empty
if (input->isEmpty())
return Status::OK();

This comment has been minimized.

Copy link
@raver119

raver119 Dec 3, 2019

Why you have deleted this shortcut? It should be here.

Signed-off-by: raver119 <raver119@gmail.com>
@raver119 raver119 merged commit 1f5e15b into master Dec 3, 2019
1 check was pending
1 check was pending
continuous-integration/jenkins/pr-head This commit is being built
Details
@raver119 raver119 deleted the shyrma_adjust branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.