From 1abfbcd4fa7494c07839de8ccabbbe70b0f4d4ae Mon Sep 17 00:00:00 2001 From: Prashansa Kulshrestha Date: Wed, 18 Mar 2026 18:06:02 +0530 Subject: [PATCH 1/2] tests: fixed konnect tests - redis.ssl_verify defaults to true now --- tests/integration/sync_test.go | 14 +++++++------- .../expected-no-skip_konnect.yaml | 2 +- .../konnect/consumer-group-scoped.expected.yaml | 1 + .../konnect/plugin-partial-2.expected.yaml | 6 ++++++ .../konnect/plugin-partial-2.yaml | 2 ++ .../plugin-shorthand-non-default.expected.yaml | 2 ++ .../009-skip-defaults/konnect/plugin.expected.yaml | 3 +++ .../009-skip-defaults/konnect/service-scoped.yaml | 2 ++ 8 files changed, 24 insertions(+), 8 deletions(-) diff --git a/tests/integration/sync_test.go b/tests/integration/sync_test.go index ac82b46c9..06a11313e 100644 --- a/tests/integration/sync_test.go +++ b/tests/integration/sync_test.go @@ -240,7 +240,7 @@ var ( "port": float64(6379), "server_name": nil, "ssl": false, - "ssl_verify": false, + "ssl_verify": true, "timeout": float64(2000), "username": nil, }, @@ -5641,7 +5641,7 @@ func testSyncSkipConsumersKonnectImpl(t *testing.T) { "sentinel_username": nil, "server_name": nil, "ssl": false, - "ssl_verify": false, + "ssl_verify": true, "timeout": float64(2000), "username": nil, }, @@ -5699,7 +5699,7 @@ func testSyncSkipConsumersKonnectImpl(t *testing.T) { "sentinel_username": nil, "server_name": nil, "ssl": false, - "ssl_verify": false, + "ssl_verify": true, "timeout": float64(2000), "username": nil, }, @@ -5757,7 +5757,7 @@ func testSyncSkipConsumersKonnectImpl(t *testing.T) { "sentinel_username": nil, "server_name": nil, "ssl": false, - "ssl_verify": false, + "ssl_verify": true, "timeout": float64(2000), "username": nil, }, @@ -8983,7 +8983,7 @@ func testSyncPartialsPluginsKonnectImpl(t *testing.T) { "read_timeout": float64(3001), "send_timeout": float64(2004), "ssl": bool(false), - "ssl_verify": bool(false), + "ssl_verify": bool(true), } t.Run("create a partial and link to a plugin via name", func(t *testing.T) { @@ -10541,7 +10541,7 @@ func testSyncPartialsTaggingKonnectImpl(t *testing.T) { "read_timeout": float64(3001), "send_timeout": float64(2004), "ssl": bool(false), - "ssl_verify": bool(false), + "ssl_verify": bool(true), }, Tags: kong.StringSlice("redis-partials"), }, @@ -10567,7 +10567,7 @@ func testSyncPartialsTaggingKonnectImpl(t *testing.T) { }, "sentinel_role": string("master"), "ssl": bool(false), - "ssl_verify": bool(false), + "ssl_verify": bool(true), }, Tags: kong.StringSlice("redis-partials"), }, diff --git a/tests/integration/testdata/dump/002-skip-consumers/expected-no-skip_konnect.yaml b/tests/integration/testdata/dump/002-skip-consumers/expected-no-skip_konnect.yaml index c976467c7..f0ce8c9d3 100644 --- a/tests/integration/testdata/dump/002-skip-consumers/expected-no-skip_konnect.yaml +++ b/tests/integration/testdata/dump/002-skip-consumers/expected-no-skip_konnect.yaml @@ -44,7 +44,7 @@ consumer_groups: sentinel_username: null server_name: null ssl: false - ssl_verify: false + ssl_verify: true timeout: 2000 username: null retry_after_jitter_max: 0 diff --git a/tests/integration/testdata/dump/009-skip-defaults/konnect/consumer-group-scoped.expected.yaml b/tests/integration/testdata/dump/009-skip-defaults/konnect/consumer-group-scoped.expected.yaml index 41f3ed30e..f9a6214a1 100644 --- a/tests/integration/testdata/dump/009-skip-defaults/konnect/consumer-group-scoped.expected.yaml +++ b/tests/integration/testdata/dump/009-skip-defaults/konnect/consumer-group-scoped.expected.yaml @@ -10,6 +10,7 @@ consumer_groups: namespace: tPHO9qtcb99zWWUWxSVDQiUpb7kj59ZQ redis: host: example.com + ssl_verify: false strategy: redis sync_rate: -1 window_size: diff --git a/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial-2.expected.yaml b/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial-2.expected.yaml index aff7097d8..2f6c23e4e 100644 --- a/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial-2.expected.yaml +++ b/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial-2.expected.yaml @@ -15,7 +15,13 @@ plugins: - abc-client client_secret: - abc-secret + cluster_cache_redis: + ssl_verify: false hide_credentials: false issuer: http://example-issuer.com + redis: + ssl_verify: false + session_redis_ssl_verify: false + ssl_verify: false enabled: true name: openid-connect diff --git a/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial-2.yaml b/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial-2.yaml index 56a371dd5..56611040e 100644 --- a/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial-2.yaml +++ b/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial-2.yaml @@ -367,3 +367,5 @@ plugins: - grpcs - http - https + - ws + - wss diff --git a/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-shorthand-non-default.expected.yaml b/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-shorthand-non-default.expected.yaml index 17d9048a3..e8dcf865d 100644 --- a/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-shorthand-non-default.expected.yaml +++ b/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-shorthand-non-default.expected.yaml @@ -6,6 +6,8 @@ plugins: minute: 10 redis: port: 6000 + ssl_verify: false redis_port: 6000 + redis_ssl_verify: false enabled: true name: rate-limiting diff --git a/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin.expected.yaml b/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin.expected.yaml index e45fa78a2..1688d2b52 100644 --- a/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin.expected.yaml +++ b/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin.expected.yaml @@ -4,5 +4,8 @@ _konnect: plugins: - config: minute: 10 + redis: + ssl_verify: false + redis_ssl_verify: false enabled: true name: rate-limiting diff --git a/tests/integration/testdata/dump/009-skip-defaults/konnect/service-scoped.yaml b/tests/integration/testdata/dump/009-skip-defaults/konnect/service-scoped.yaml index f43beb247..fa9ec7155 100644 --- a/tests/integration/testdata/dump/009-skip-defaults/konnect/service-scoped.yaml +++ b/tests/integration/testdata/dump/009-skip-defaults/konnect/service-scoped.yaml @@ -21,6 +21,8 @@ services: - grpcs - http - https + - ws + - wss - config: allowed_content_types: - application/json From cb1391648e771c8c4ca445d5f02399dd139f9f8d Mon Sep 17 00:00:00 2001 From: Prashansa Kulshrestha Date: Fri, 20 Mar 2026 12:17:09 +0530 Subject: [PATCH 2/2] tests: corrected test files --- .../009-skip-defaults/konnect/plugin-partial-2.expected.yaml | 1 + .../dump/009-skip-defaults/konnect/plugin-partial.expected.yaml | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial-2.expected.yaml b/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial-2.expected.yaml index 2f6c23e4e..475133240 100644 --- a/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial-2.expected.yaml +++ b/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial-2.expected.yaml @@ -5,6 +5,7 @@ partials: - config: host: example.com keepalive_backlog: 0 + ssl_verify: false id: 9e060517-7cae-4425-9ff1-1df11d0e9b5a name: my-partial-ee type: redis-ee diff --git a/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial.expected.yaml b/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial.expected.yaml index 647efc678..6e2a42fcd 100644 --- a/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial.expected.yaml +++ b/tests/integration/testdata/dump/009-skip-defaults/konnect/plugin-partial.expected.yaml @@ -6,6 +6,7 @@ partials: host: example.com keepalive_backlog: 0 password: redis-pass + ssl_verify: false username: redis-user id: 65a8785d-2e4a-4adb-8805-63e1141219cd name: my-partial-ee