New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: Add details about log levels #1003

Merged
merged 6 commits into from Oct 31, 2018

Conversation

Projects
None yet
2 participants
@palash25
Contributor

palash25 commented Oct 30, 2018

Closes: #907

NOTE: Please read the CONTRIBUTING.md guidelines before submitting your patch,
and ensure you followed them all:

https://github.com/Kong/docs.konghq.com/blob/master/CONTRIBUTING.md

Summary

Added details about different log levels in the logging.md document from this post https://discuss.konghq.com/t/production-kong-log-level/1949/5

Full changelog

  • Edited the logging docs

Issues resolved

Fix #907

Checklist:

@palash25 palash25 force-pushed the palash25:logging branch from 4b1d549 to b2ac777 Oct 30, 2018

@coopr coopr requested review from Kong/team-core and john-paul-keenan Oct 30, 2018

@coopr coopr added the needs review label Oct 30, 2018

@coopr

Great start!

Show resolved Hide resolved app/0.14.x/logging.md Outdated
Show resolved Hide resolved app/0.14.x/logging.md Outdated
Show resolved Hide resolved app/0.14.x/logging.md Outdated

@coopr coopr added the needs changes label Oct 30, 2018

@palash25 palash25 force-pushed the palash25:logging branch from b2ac777 to 95cb03a Oct 31, 2018

@palash25 palash25 force-pushed the palash25:logging branch from 95cb03a to 2deb6a6 Oct 31, 2018

@palash25

This comment has been minimized.

Contributor

palash25 commented Oct 31, 2018

@coopr I have made the requested changes please take a look

coopr added some commits Oct 31, 2018

Revert "Merge branch 'logging' of https://github.com/palash25/docs.ko…
…nghq.com into pr/1003"

This reverts commit 71feb6f, reversing
changes made to b2ac777.
@coopr

This comment has been minimized.

Member

coopr commented Oct 31, 2018

I seemed to have messed things up with merges and reverts - I corrected those issues, and made a few tune-ups to this PR to say sorry!

@coopr

This comment has been minimized.

Member

coopr commented Oct 31, 2018

Great work @palash25 thanks so much for the contribution, go Hacktoberfest!! 🎃

@coopr coopr merged commit 6224f78 into Kong:master Oct 31, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@palash25 palash25 deleted the palash25:logging branch Nov 1, 2018

kikito added a commit that referenced this pull request Dec 4, 2018

docs(logging) Add log level details (#1003)
* docs(logging) Add details about log levels

* docs(logging) corrected links and placement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment