New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make numbered list styling consistent #965

Merged
merged 3 commits into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@danimart1991
Contributor

danimart1991 commented Oct 20, 2018

Summary

Move ol style from extension.less to page.less to make numbered list styling consistent.

Issues resolved

Fix #914

Checklist:

@coopr

This comment has been minimized.

Member

coopr commented Oct 22, 2018

Thanks @danimart1991 ! I've confirmed that numbered lists now have the "connected circles" styling - however, a change in the circle size has appeared which we don't want. See the following GIF, in which I'm switching back and forth between the original circle size, and the size we get with this PR currently.

circles

Any chance you could make the circle sizes consistent across the site?

Also, have a look at the yellow box near the top of http://localhost:3000/0.14.x/getting-started/configuring-a-service/ and http://localhost:3000/0.14.x/getting-started/enabling-plugins/ - what can be done to make that look better?

@coopr coopr added the needs changes label Oct 22, 2018

@danimart1991

This comment has been minimized.

Contributor

danimart1991 commented Oct 22, 2018

Fixed Sizes, all circles now has 36px.

@coopr coopr added needs review and removed needs changes labels Oct 22, 2018

@coopr

This comment has been minimized.

Member

coopr commented Oct 22, 2018

OK, the circles are now the right size, but we have a new issue:

authentication_reference_-v0_14_x___kong-_open-source_api_management_and_microservice_management

Also, please see:

...have a look at the yellow box near the top of http://localhost:3000/0.14.x/getting-started/configuring-a-service/ and http://localhost:3000/0.14.x/getting-started/enabling-plugins/ - what can be done to make that look better?

@coopr coopr added needs changes and removed needs review labels Oct 22, 2018

@danimart1991

This comment has been minimized.

Contributor

danimart1991 commented Oct 23, 2018

Ok I fix all the issues I could check, including the one you point. Respect to yellow box, it's an alert box, has this style before I touch the code, and I like this style. I think it's not related to this issue instead.

@coopr

This comment has been minimized.

Member

coopr commented Oct 23, 2018

Looking good! Thanks for working with us on this great contribution @danimart1991 - go Hacktoberfest!! 🎃

@coopr coopr merged commit 4b73968 into Kong:master Oct 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danimart1991 danimart1991 deleted the danimart1991:bug/914 branch Oct 24, 2018

john-paul-keenan added a commit that referenced this pull request Nov 6, 2018

docs(prometheus) typos and wording improvement (#945)
docs(getting-started-adding-consumers) fixed formatting (#950)

docs(*) fix typos (#951)

docs(getting-started/configuring-a-service) fixed formatting (#954)

docs(getting-started/quickstart) fixed formatting (#955)

docs(getting-started/enabling-plugins) fix formatting (#952)

docs(hub) update optum kong-splunk-log plugin (#949)

* docs(hub) update optum kong-splunk-log plugin

* docs(hub-kong-splunk-log) update compatibility

https://docs.konghq.com/enterprise/changelog/#0-32-2018-05-24 tells us that Kong Enterprise 0.32 was based on Kong 0.13.1 - as such, I'm moving Kong Enterprise 0.32-x from Incompatible to Compatible.

* docs(hub-kong-splunk-log) tune up formatting

docs(hub-openid-connect) correct extension type (#948)

docs(install-macos) change OSX to macOS (#953)

* docs(text): Change OS X to macOS

* Changed OS X occurences to macOS

From #470

* docs(install-macos) update osx to macos

fix(rbac) display tables correctly (#957)

Adding needed blank line to display tables as such.

docs(install-dc/os) update aws install url (#961)

docs(install-dcos) fix typo in kong universe link (#970)

docs(readme) Update links to https (#966)

docs(gulpfile.js) capitalization (#959)

docs(plugin-development) wording choice (#980)

style(numbered-lists) Make styling consistent (#965)

* Make numbered list styling consistent

* Fix sizes

* Fix line position, padding and list-style in alerts

* Fixes #914

More work Correcting the names

I had missed  few things hen looking for all the occurrences, so I went through and caught them

missed an community reference

missed community reference

removed word community

removed community reference

corrected name

judithpatudith added a commit to judithpatudith/docs.konghq.com that referenced this pull request Nov 14, 2018

docs(prometheus) typos and wording improvement (Kong#945)
docs(getting-started-adding-consumers) fixed formatting (Kong#950)

docs(*) fix typos (Kong#951)

docs(getting-started/configuring-a-service) fixed formatting (Kong#954)

docs(getting-started/quickstart) fixed formatting (Kong#955)

docs(getting-started/enabling-plugins) fix formatting (Kong#952)

docs(hub) update optum kong-splunk-log plugin (Kong#949)

* docs(hub) update optum kong-splunk-log plugin

* docs(hub-kong-splunk-log) update compatibility

https://docs.konghq.com/enterprise/changelog/#0-32-2018-05-24 tells us that Kong Enterprise 0.32 was based on Kong 0.13.1 - as such, I'm moving Kong Enterprise 0.32-x from Incompatible to Compatible.

* docs(hub-kong-splunk-log) tune up formatting

docs(hub-openid-connect) correct extension type (Kong#948)

docs(install-macos) change OSX to macOS (Kong#953)

* docs(text): Change OS X to macOS

* Changed OS X occurences to macOS

From Kong#470

* docs(install-macos) update osx to macos

fix(rbac) display tables correctly (Kong#957)

Adding needed blank line to display tables as such.

docs(install-dc/os) update aws install url (Kong#961)

docs(install-dcos) fix typo in kong universe link (Kong#970)

docs(readme) Update links to https (Kong#966)

docs(gulpfile.js) capitalization (Kong#959)

docs(plugin-development) wording choice (Kong#980)

style(numbered-lists) Make styling consistent (Kong#965)

* Make numbered list styling consistent

* Fix sizes

* Fix line position, padding and list-style in alerts

* Fixes Kong#914

More work Correcting the names

I had missed  few things hen looking for all the occurrences, so I went through and caught them

missed an community reference

missed community reference

removed word community

removed community reference

corrected name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment