New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(syntax) dont allow selecting generic prompt symbol #969

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
2 participants
@darrenjennings
Member

darrenjennings commented Oct 22, 2018

Summary

Dont allow user to select generic prompt $. This will only work when the markdown language is used e.g. ```bash. Will need to search and find places where bash is not specified in another PR.

image

Issues resolved

Fix #939

Checklist:

@coopr

This comment has been minimized.

Member

coopr commented Oct 22, 2018

Will need to search and find places where bash is not specified in another PR.

Could we do it in this PR, so we can call this done done? If it is tedious, it'd be acceptable to do that in just the latest Kong 0.14 and Kong Enterprise 0.33 and Hub docs.

@coopr coopr added the needs review label Oct 22, 2018

cfreksen added a commit to cfreksen/docs.konghq.com that referenced this pull request Oct 24, 2018

docs(*) Add bash annotation to markdown code snippets
Needed for Kong#969

Signed-off-by: cfreksen <casper@freksen.dk>

@cfreksen cfreksen referenced this pull request Oct 24, 2018

Merged

docs(*) Add bash annotations to markdown code snippets #985

3 of 4 tasks complete

darrenjennings added a commit that referenced this pull request Oct 24, 2018

@darrenjennings

This comment has been minimized.

Member

darrenjennings commented Oct 24, 2018

@coopr thanks to @cfreksen in #985 we should be able to merge this now

@coopr

This comment has been minimized.

Member

coopr commented Oct 24, 2018

Excellent, thanks @darrenjennings and @cfreksen !

@coopr coopr merged commit b6a2fe6 into master Oct 24, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@coopr coopr deleted the fix/939-dont-select-command-prompt-$ branch Oct 24, 2018

@coopr coopr referenced this pull request Nov 1, 2018

Merged

Add install for Microsoft Azure #1018

3 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment