New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currently active version to version dropdown #998

Merged
merged 3 commits into from Oct 31, 2018

Conversation

Projects
None yet
3 participants
@josiahdahl
Contributor

josiahdahl commented Oct 26, 2018

Summary

Add the currently selected version of the documentation to the version selection dropdown so that users can see what version they're viewing easily.

Documentation Example
image

Plugin Example
image

Lua Reference Example
image

I couldn't find a way that looked good to change the width to make the button and dropdown the same size, so that's left off of this PR.

Full changelog

  • Show currently selected documentation version in version dropdown

Issues resolved

Fix #886

Checklist:

@coopr

This comment has been minimized.

Member

coopr commented Oct 27, 2018

Very nice screenshots - thanks so much for those!

@adamjkuhn note:

I couldn't find a way that looked good to change the width to make the button and dropdown the same size, so that's left off of this PR.

Perhaps soon is the time for you to work some of your magic on our rather non-standard dropdown implementation?

@coopr coopr added the needs review label Oct 27, 2018

@coopr

This comment has been minimized.

Member

coopr commented Oct 31, 2018

Wow, nice work! I want to get another set of 👀 on this before I merge...

@coopr coopr requested a review from adamjkuhn Oct 31, 2018

@adamjkuhn

This comment has been minimized.

adamjkuhn commented Oct 31, 2018

This looks great to me- I've tested in multiple environments and I do believe it's good to go. Great work!

@coopr coopr referenced this pull request Oct 31, 2018

Open

Add better version switching experience #1005

24 of 26 tasks complete
@coopr

This comment has been minimized.

Member

coopr commented Oct 31, 2018

Let's :shipit: - big thanks @josiahdahl , go Hacktoberfest! 🎃

@coopr coopr merged commit 6ddd83a into Kong:master Oct 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

kikito added a commit that referenced this pull request Dec 4, 2018

style(version-dropdown) Highlight currently active version (#998)
* docs: Add current version to ext and docs dropdown

* docs: Add current version to Lua API refence menu

* docs: Add '(latest)' to dropdowns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment