Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Atlassian ASAP Auth doesn't match the spec #2219

Closed
Gangezilla opened this issue May 27, 2020 · 3 comments
Closed

Implementation of Atlassian ASAP Auth doesn't match the spec #2219

Gangezilla opened this issue May 27, 2020 · 3 comments
Assignees
Labels
B-bug Bug: general classification E-good-first-issue Experience required: Beginner / New needs-triage

Comments

@Gangezilla
Copy link

Describe the bug
Hi there! According to the spec for ASAP, you should be able to pass an array of values for the 'audience' field. I've bolded the relevant section from the spec here: “aud”: audience, as defined by JWT, with the difference that here it is mandatory. Note that the value of this claim may be a single string value **or an array of string values**. Currently the value is passed as a string, as seen here

const asapAudience = this.renderTextInput('Audience (aud)', 'audience', 'text/plain', value =>

To Reproduce

  1. Create a new request
  2. Select 'Atlassian ASAP' in the Auth dropdown
  3. Fill in a value or series of values. I've tried values like audience1 audience2, [audience1, audience2], ["audience1", "audience2"], audience1, audience2`
  4. If you look at the values that get created the token, you'll see that the audience field is a string.
{
  iss: 'issuer',
  sub: 'sub',
  aud: 'audience1 audience2',
  jti: '98uhj9889j9889',
  iat: 123123123123,
  exp: 123123123123
}

Expected behavior
As described in the spec, the audience field should look like `["audience1, "audience2"] instead of "audience1 audience2"

Desktop (please complete the following information):

@Gangezilla Gangezilla added the B-bug Bug: general classification label May 27, 2020
@nijikokun nijikokun added the E-good-first-issue Experience required: Beginner / New label May 27, 2020
@stale
Copy link

stale bot commented May 31, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@kreosus
Copy link
Contributor

kreosus commented Oct 6, 2022

Hi @Gangezilla
Have you been able to reproduce this error from our newest release located here: https://github.com/Kong/insomnia/releases

@kreosus kreosus self-assigned this Oct 6, 2022
@kreosus
Copy link
Contributor

kreosus commented Oct 13, 2022

closing to lack of activity

@kreosus kreosus closed this as completed Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: general classification E-good-first-issue Experience required: Beginner / New needs-triage
Projects
None yet
Development

No branches or pull requests

4 participants