Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insomnia 2021.2.0 doesn't use local dns server #3234

Closed
xwillq opened this issue Mar 24, 2021 · 7 comments
Closed

Insomnia 2021.2.0 doesn't use local dns server #3234

xwillq opened this issue Mar 24, 2021 · 7 comments
Labels
B-bug Bug: general classification D-node-libcurl Dependency: Node Libcurl P-critical Priority: Critical S-shipped Status: Shipped S-verified Status: Verified by maintainer
Milestone

Comments

@xwillq
Copy link

xwillq commented Mar 24, 2021

Describe the bug
Latest version of insomnia doesn't use local dns server if there are any other options

To Reproduce
Steps to reproduce the behavior:

  1. Configure local dns server
  2. Configure local dns server as preferred and some other server as alternative (for example 1.1.1.1)
  3. Make a request to the domain which should be resolved with local dns server
  4. See Error: Couldn't resolve host name
  5. If you capture traffic with wireshark or check logs of local dns server, you can see that it didn't receive any queries

Expected behavior
Insomnia uses local dns server for dns lookups

Screenshots
DNS lookup when making request with Insomnia 2021.1.1
image

DNS lookup when making request with Chrome
image

DNS lookup when making request with Insomnia 2021.2.0
image

Desktop:

  • OS: Windows 10
  • Installation Method: Installer from github releases
  • App Version: 2021.2.0

Additional context
If you remove all dns servers except the localhost, then insomnia will use localhost.

@xwillq xwillq added B-bug Bug: general classification S-unverified Status: Unverified by maintainer labels Mar 24, 2021
@illuz
Copy link

illuz commented Mar 24, 2021

The same problem after upgrade to 2021.2.0 today.

@DMarby
Copy link
Contributor

DMarby commented Mar 24, 2021

Hi @xwillq,

Thank you for reporting this! We have confirmed the issue, and believe it's likely due to our recent upgrade of the node-libcurl dependency for the 2021.2.0 release, which changed what DNS resolver backend is being used.

We are looking into ways to address it, and hope to get it fixed as soon as possible.

@DMarby DMarby added B-regression D-node-libcurl Dependency: Node Libcurl S-verified Status: Verified by maintainer and removed S-unverified Status: Unverified by maintainer labels Mar 24, 2021
@shanegray
Copy link

Is there a workaround for the time being? Or a way to downgrade?

@jogat
Copy link

jogat commented Mar 24, 2021

@shanegray

Is there a workaround for the time being? Or a way to downgrade?

Go to: https://github.com/Kong/insomnia/releases/tag/core%402021.1.1

@nijikokun nijikokun added the P-critical Priority: Critical label Mar 24, 2021
@nijikokun
Copy link
Contributor

nijikokun commented Mar 24, 2021

Update: we have identified that it is indeed a regression from the update to node-libcurl that impacts all platforms and we are working with the maintainer to get a build out sometime tonight or tomorrow morning that doesn't use c-ares for DNS to fix the issue.

In the meantime we have pulled 2021.2 from the auto-update api to reduce the impact on users, for those who are impacted please download the previous release mentioned here.

@nijikokun
Copy link
Contributor

nijikokun commented Mar 24, 2021

Update: new build for node-libcurl is up, we are preparing a new patch release for Insomnia which is going into testing and will be released shortly. Thank you to everyone who was a part of making this happen. ❤️

Test build can be found here.

@nijikokun nijikokun added S-in-progress Status: In Progress S-shipped Status: Shipped and removed S-in-progress Status: In Progress labels Mar 24, 2021
@nijikokun
Copy link
Contributor

nijikokun commented Mar 24, 2021

Patch release is now live! Closing! 🙌

You can download the latest release here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: general classification D-node-libcurl Dependency: Node Libcurl P-critical Priority: Critical S-shipped Status: Shipped S-verified Status: Verified by maintainer
Projects
None yet
Development

No branches or pull requests

6 participants