Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Secure Text option for prompts #1036

Merged
merged 2 commits into from Jul 5, 2018
Merged

Add Secure Text option for prompts #1036

merged 2 commits into from Jul 5, 2018

Conversation

@flippidippi
Copy link
Contributor

flippidippi commented Jul 5, 2018

Add support for "Secure Text" option for prompts.

Closes #962

@welcome

This comment has been minimized.

Copy link

welcome bot commented Jul 5, 2018

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

Copy link
Contributor

gschier left a comment

Woah, beautiful!

Just one thought. Maybe we should refrain from using the word "secure" in favor of something like "hide" or "mask" (like in your hint)? My first thought when seeing this was that it was encrypted in some way.

@flippidippi

This comment has been minimized.

Copy link
Contributor Author

flippidippi commented Jul 5, 2018

Ok I can change that. Would "Mask Text" work?

Phillip Lanclos
@gschier

This comment has been minimized.

Copy link
Contributor

gschier commented Jul 5, 2018

Ya, that sounds good!

@gschier
gschier approved these changes Jul 5, 2018
Copy link
Contributor

gschier left a comment

Awesome stuff!

@gschier gschier merged commit caeb642 into Kong:develop Jul 5, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Jul 5, 2018

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

luizmariz pushed a commit to luizmariz/insomnia that referenced this pull request Jan 22, 2020
* Add Secure Text option for prompts closes Kong#962

* Change prompt secure text name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.