Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bar color indicator for environments #1042

Merged
merged 2 commits into from Jul 12, 2018
Merged

Add bar color indicator for environments #1042

merged 2 commits into from Jul 12, 2018

Conversation

@tippl
Copy link
Contributor

tippl commented Jul 12, 2018

Add a bar color indicator along with new a setting to choose whether to use the original dot or the new bar.

Closes #995

@welcome

This comment has been minimized.

Copy link

welcome bot commented Jul 12, 2018

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

Copy link
Contributor

gschier left a comment

Thanks for getting this done @tippl! Just a few minor comments.

@@ -25,7 +25,8 @@ type BaseSettings = {
nunjucksPowerUserMode: boolean,
deviceId: string | null,
updateChannel: string,
updateAutomatically: boolean
updateAutomatically: boolean,
colorIndicatorType: string

This comment has been minimized.

Copy link
@gschier

gschier Jul 12, 2018

Contributor

Should be renamed to be more descriptive. Perhaps environmentHighlightColorStyle?

@@ -144,6 +144,19 @@ class General extends React.PureComponent<Props> {
</label>
</div>

<div className="form-control form-control--outlined pad-top-sm">
<label>
Color Indicator Type

This comment has been minimized.

Copy link
@gschier

gschier Jul 12, 2018

Contributor

Same here. This should be more descriptive. Like "Environment Highlight Color Style." Could also add a help tooltip (see Nunjucks setting for example) because many will not even know what environment colors are.

activeEnvironment &&
activeEnvironment.color &&
settings.colorIndicatorType === 'bar' ? (
<div

This comment has been minimized.

Copy link
@gschier

gschier Jul 12, 2018

Contributor

This is probably better suited for the #wrapper element (below).

A style of border-top: 5px solid <COLOR> should do the trick.

Copy link
Contributor

gschier left a comment

Nice, looks good now! 👍

@gschier gschier merged commit f681d13 into Kong:develop Jul 12, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Jul 12, 2018

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

luizmariz pushed a commit to luizmariz/insomnia that referenced this pull request Jan 22, 2020
* Add bar color indicator for environments

* Fix according to code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.