Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDN support #1176

Merged
merged 3 commits into from Sep 30, 2018
Merged

EDN support #1176

merged 3 commits into from Sep 30, 2018

Conversation

@JoelSanchez
Copy link
Contributor

JoelSanchez commented Sep 25, 2018

Solves #1173
Adds EDN to the list of possible request types.
image
Enables EDN support in CodeMirror and prettifies the code
image
Adds the application/edn mime type
image

@welcome

This comment has been minimized.

Copy link

welcome bot commented Sep 25, 2018

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

Copy link
Contributor

gschier left a comment

Beautiful PR! Just a couple minor comments 💯

@@ -2,6 +2,7 @@ import * as React from 'react';
import PropTypes from 'prop-types';
import autobind from 'autobind-decorator';
import CodeMirror from 'codemirror';
import 'codemirror/mode/clojure/clojure';

This comment has been minimized.

Copy link
@gschier

gschier Sep 26, 2018

Contributor

This should be in ./base-imports 😄

@@ -152,7 +152,8 @@
"tough-cookie": "^2.3.1",
"uuid": "^3.0.0",
"vkbeautify": "^0.99.1",
"whatwg-fetch": "^2.0.1"
"whatwg-fetch": "^2.0.1",
"zprint-clj": "^0.2.0"

This comment has been minimized.

Copy link
@gschier

gschier Sep 26, 2018

Contributor

package-lock.json needs to be included in this PR as well. I think NPM 5+ generates package-lock.json when npm install is run 👍

This comment has been minimized.

Copy link
@JoelSanchez

JoelSanchez Sep 27, 2018

Author Contributor

So, I added the package-lock.json, but it seems to be doing more changes than needed. Should I just commit the line relevant to zprint?

@JoelSanchez JoelSanchez force-pushed the JoelSanchez:feature/edn-support branch from 1c6d83c to 4a7c4ba Sep 27, 2018
@JoelSanchez

This comment has been minimized.

Copy link
Contributor Author

JoelSanchez commented Sep 27, 2018

Did a rebase.

Copy link
Contributor

gschier left a comment

Awesome stuff! So happy to have this in the app 😄

@gschier gschier merged commit d9ef8b5 into Kong:develop Sep 30, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Sep 30, 2018

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

@JoelSanchez

This comment has been minimized.

Copy link
Contributor Author

JoelSanchez commented Sep 30, 2018

Thank you. I think many Clojure devs will turn to Insomnia when/if they need to use an EDN api (starting by my coworkers...)

luizmariz pushed a commit to luizmariz/insomnia that referenced this pull request Jan 22, 2020
* EDN support

* Move Clojure codemirror import

* Add package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.