Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordered workspace list #1179

Merged
merged 3 commits into from Sep 30, 2018
Merged

Conversation

@Masov
Copy link
Contributor

Masov commented Sep 25, 2018

Closes #1161

Added Ordered Workspace List checkbox in settings. When the checkbox is selected, workspaces on the list are sorted.

Michał Zaborowski
@ryanprior

This comment has been minimized.

Copy link

ryanprior commented Sep 25, 2018

Is there any practical reason to turn off workspace sorting? If not, maybe just make this the standard behavior with no checkbox.

@Masov

This comment has been minimized.

Copy link
Contributor Author

Masov commented Sep 26, 2018

The only reason why I added the checkbox is that otherwise, the default behaviour would be changed and maybe someone is already accustomed to having this particular workspace on this specific position.

@gschier

This comment has been minimized.

Copy link
Contributor

gschier commented Sep 26, 2018

I agree with @ryanprior. I think we can just turn this on by default and remove the setting (nice work on that though by the way 👍).

Further down the road, I think the ideal would be to allow the user to order them with drag-n-drop.

Michał Zaborowski added 2 commits Sep 27, 2018
Michał Zaborowski
@Masov

This comment has been minimized.

Copy link
Contributor Author

Masov commented Sep 27, 2018

It is now turned on by default.

Copy link
Contributor

gschier left a comment

Awesome, so simple! 👍

@gschier gschier merged commit 018d75e into Kong:develop Sep 30, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Masov Masov deleted the Masov:feature/ordered-workspace-list branch Oct 1, 2018
luizmariz pushed a commit to luizmariz/insomnia that referenced this pull request Jan 22, 2020
* Ordered workspace list

* Remove workspace list order from settings

* Remove unused const
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.