Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes 1225 #1230

Merged
merged 4 commits into from Nov 6, 2018
Merged

Closes 1225 #1230

merged 4 commits into from Nov 6, 2018

Conversation

@danothemen
Copy link
Contributor

danothemen commented Oct 26, 2018

I have added a utility function to misc.js to allow the data directory to be set via an environment variable called INSOMNIA_DATA_PATH. I did not change anything with regards to the temp directory.

danothemen added 4 commits Oct 25, 2018
… so that an environment variable can be set for the data directory.
@gschier
gschier approved these changes Nov 6, 2018
Copy link
Contributor

gschier left a comment

Nice one!

@gschier gschier merged commit 37ccd12 into Kong:develop Nov 6, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Nov 6, 2018

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

luizmariz pushed a commit to luizmariz/insomnia that referenced this pull request Jan 22, 2020
* Updated all references to use the getDataDirectory function from misc so that an environment variable can be set for the data directory.

* Did some minor code formatting cleanup

* Got rid of some unused vars

* More unused var cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.