Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight focused keyboard tab (#1299) #1300

merged 2 commits into from Dec 12, 2018


Copy link

tostringtheory commented Dec 12, 2018

Closes #1299 .

Before change (focused on Overview tab via keyboard):


After change:


The tab is only highlighted when focused via the keyboard, else it appears as it does with current implementation.

James Sampson and others added 2 commits Dec 12, 2018

This comment has been minimized.

Copy link

gschier commented Dec 12, 2018

Added some more to this to make tabbing work between tabs too

@gschier gschier merged commit e0881c6 into Kong:develop Dec 12, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
continuous-integration/travis-ci/pr The Travis CI build passed
luizmariz pushed a commit to luizmariz/insomnia that referenced this pull request Jan 22, 2020
* Apply styling to keyboard focused tabs

* Add tab-index to tabs so only their contents are focusable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.