Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch JS snippet #1343

Merged
merged 3 commits into from Mar 11, 2019
Merged

Fetch JS snippet #1343

merged 3 commits into from Mar 11, 2019

Conversation

@peoplenarthax
Copy link
Contributor

peoplenarthax commented Jan 22, 2019

Closes #1313

Add simple JavaScript Fetch snippet with ES6 syntax.

@welcome

This comment has been minimized.

Copy link

welcome bot commented Jan 22, 2019

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@peoplenarthax

This comment has been minimized.

Copy link
Contributor Author

peoplenarthax commented Jan 31, 2019

Can I get a review of this @gschier ?

Copy link
Contributor

gschier left a comment

nice!

@gschier gschier merged commit 7fe101b into Kong:develop Mar 11, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Mar 11, 2019

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

@ilrein

This comment has been minimized.

Copy link

ilrein commented Jul 26, 2019

@gschier @peoplenarthax I was just trying this out and I noticed the generated fetch code doesn't include a body. I assume this is a mistake?

@gschier

This comment has been minimized.

Copy link
Contributor

gschier commented Aug 21, 2019

@ilrein please open a new issue if you are having trouble. I just checked quickly and I can see a fetch body on my end so perhaps it's related to the specific request you are trying to send.

@Kong Kong locked as resolved and limited conversation to collaborators Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.