Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request authentication getter and setter to plugin request context. #1393

Conversation

samirnijenhuis
Copy link

@samirnijenhuis samirnijenhuis commented Mar 2, 2019

This PR enables plugin developers to set and get the authentication configuration of a request.

I built a small plugin that allows me to define my OAuth 2 settings on an environment and automate the authentication for every request I add to my workspace. This way I don't have to look / configure auth settings for every single request.

The following issues could benefit from this pr:
#1116
#790

@welcome
Copy link

welcome bot commented Mar 2, 2019

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

Copy link
Contributor

@gschier gschier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment. Looks good otherwise! This will be super useful

packages/insomnia-app/app/plugins/context/request.js Outdated Show resolved Hide resolved
Copy link
Contributor

@gschier gschier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this!

@gschier gschier merged commit 6717135 into Kong:develop Apr 18, 2019
@welcome
Copy link

welcome bot commented Apr 18, 2019

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants