Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add keyboard shortcuts editor in settings #1403
If the add option is chosen, then a new modal is displayed to capture user's pressed key combinations.
There are also options to reset the keyboard shortcuts to the default values. The first one is "Reset All" which will reset all of the shortcuts in the list. The second one can be found in the dropdown, and will only appear if the shortcuts are different from the default ones.
I removed the shortcuts in Electron's toolbar's menu, because IMO they are redundant and cannot be overridden without reloading the app.
gschier left a comment
This looks really good! I think we need to keep the shortcuts in the Electron toolbar though. Even if they're just dummy ones for display purposes only. Mac users expect those to be there.
If you add them back, I might be able to hook something up so that they change without reloading the app.