Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] [SwaggerV2] Create Folders from implicit defined tags #1723

Merged
merged 3 commits into from Nov 22, 2019

Conversation

@beardeddragon5
Copy link
Contributor

beardeddragon5 commented Oct 11, 2019

Swagger Tags can be defined in the document root

...
tags:
  - name: tagname
    description: tagdescription
...

or implicit in every method

...
get:
  operationId: "getsomething"
  tags:
    - tagname
...

The implicit variant can not define an description.

With this little change the implicit tags get imported as folders as well

@beardeddragon5 beardeddragon5 changed the title Create Folders from implicit defined tags [Feature] [SwaggerV2] Create Folders from implicit defined tags Oct 11, 2019
Copy link
Contributor

gschier left a comment

Awesome work!

Can you add a test fixture case to reflect this change?

@beardeddragon5

This comment has been minimized.

Copy link
Contributor Author

beardeddragon5 commented Nov 4, 2019

Yes, i can add a few test fixtures. The tests didn't run correctly on my side and always returned "passed". Not ideal to write tests.

@beardeddragon5 beardeddragon5 requested a review from gschier Nov 11, 2019
Copy link
Contributor

gschier left a comment

Awesome, thanks for updating those fixtures! 🎊

@gschier gschier merged commit b59759d into Kong:develop Nov 22, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.