Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] [SwaggerV2] Import Documentation and Authentification #1724

Merged
merged 4 commits into from Nov 22, 2019

Conversation

@beardeddragon5
Copy link
Contributor

beardeddragon5 commented Oct 12, 2019

Partially implements #1698
Closes #1007

Partially implements #1698
Fixes #1007
Copy link
Contributor

gschier left a comment

Woah, this is amazing! Would you be able to add some basic test fixtures for these?

@beardeddragon5

This comment has been minimized.

Copy link
Contributor Author

beardeddragon5 commented Nov 4, 2019

Yes, i can add a few test fixtures. The tests didn't run correctly on my side and always returned "passed". Not ideal to write tests.

@beardeddragon5 beardeddragon5 requested a review from gschier Nov 11, 2019
@gschier

This comment has been minimized.

Copy link
Contributor

gschier commented Nov 22, 2019

Thanks for updating this! Can you pull in develop again, fix the conflicting fixtures, and re-push? Should be good to merge after that 😄

@gschier

This comment has been minimized.

Copy link
Contributor

gschier commented Nov 22, 2019

Nevermind, I was able to on GitHub!

@gschier gschier merged commit 65cd4b0 into Kong:develop Nov 22, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.