Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Added request-specific followRedirects setting #1737

Merged
merged 2 commits into from Oct 31, 2019

Conversation

@NilayMajorwar
Copy link
Contributor

NilayMajorwar commented Oct 18, 2019

This PR adds the "Follow redirects" override setting to request model (Closes #915). The "Follow redirects" setting in request settings has three options:

  • Use global setting: Default setting - the request uses the global setting chosen in preferences
  • Follow redirects: Overrides global setting, follows redirects.
  • Don't follow redirects: Overrides global setting, does not follow redirects.

ins

@welcome

This comment has been minimized.

Copy link

welcome bot commented Oct 18, 2019

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@NilayMajorwar NilayMajorwar changed the title Added request-specific followRedirects setting [Feature] Added request-specific followRedirects setting Oct 19, 2019
Copy link
Contributor

gschier left a comment

Nice, I love this. Great work on both the code and UX. I was struggling to come up with a good UI for providing request-level overrides but a <select> works really well.

@gschier gschier merged commit ad278ea into Kong:develop Oct 31, 2019
1 check failed
1 check failed
continuous-integration/appveyor/pr AppVeyor build failed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Oct 31, 2019

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.