Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Added display support for X-HTTP-Method-Override #1744

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@NilayMajorwar
Copy link
Contributor

NilayMajorwar commented Oct 19, 2019

This PR adds first class display support for the X-HTTP-Method-Override header in the sidebar.
Whenever the X-HTTP-Method-Override header is set with a valid method name on a request, the request in sidebar shows the overriding method, with the overridden method shown smaller.
Closes #1334.

ins

Copy link
Contributor

gschier left a comment

Nice, I love this addition. Great implementation as well 🙌🏻

@@ -117,6 +117,16 @@ export function removeVowels(str: string): string {
return str.replace(/[aeiouyAEIOUY]/g, '');
}

export function formatMethodName(method: string): string {

This comment has been minimized.

Copy link
@gschier

gschier Oct 31, 2019

Contributor

Nice work on pulling this out into a helper 👍

This comment has been minimized.

Copy link
@NilayMajorwar

NilayMajorwar Oct 31, 2019

Author Contributor

Thanks!

@gschier gschier merged commit 157ccac into Kong:develop Oct 31, 2019
1 check failed
1 check failed
continuous-integration/appveyor/pr AppVeyor build failed
Details
@NilayMajorwar NilayMajorwar deleted the NilayMajorwar:method-show branch Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.