Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic height of window "Edit variable" - "Line preview" #1800

Merged
merged 1 commit into from Nov 22, 2019

Conversation

@elemanhillary
Copy link
Contributor

elemanhillary commented Nov 22, 2019

Closes #1791

@elemanhillary elemanhillary changed the title fix(height): Dynamic height of window "Edit variable" - "Line preview" Nov 22, 2019
Copy link
Contributor

gschier left a comment

Nice one, this will be awesome once it's in.

A couple things though after testing it out locally:

  • It doesn't resize if you switch variables. componentDidUpdate() should be able to help
  • The textarea should have a max height

image

Looking forward to getting this merged soon!

- add dynamic height of window "Edit variable" - "Line preview"
@elemanhillary elemanhillary force-pushed the elemanhillary:fix/dynamic_height_window branch from e920b67 to 88e4b2a Nov 22, 2019
Copy link
Contributor

gschier left a comment

Thanks for this one!

@gschier gschier merged commit b4b60f3 into Kong:develop Nov 22, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sergey-dubinin

This comment has been minimized.

Copy link

sergey-dubinin commented Nov 23, 2019

Thanks a lot, guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.