Add Array/property length in JSON code fold widget #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschier
approved these changes
Dec 20, 2019
|
This is no longer working on the latest insomnia version :( Version: Insomnia 2021.7.2 |
|
I confirm it does not work for lists, it works for dicts only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1799.
As per title, notes are in the issue 馃槃
The code being used is the same as used by the code-folding example in CodeMirror docs, which I added and was reviewed by the maintainer of CodeMirror. On his suggestion, the changes to the core library were minimal (allow for the widget to be a callback), with the actual logic to be defined by consumers.