Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix componentWillUnmount lifecycle method #1951

Merged
merged 1 commit into from Feb 18, 2020
Merged

Conversation

@serpilacar
Copy link
Contributor

serpilacar commented Feb 18, 2020

There is no lifecycle method named UNSAFE_componentWillUnmount, it's just componentWillUnmount.

Closes: #1949

Copy link
Contributor

gschier left a comment

Thanks so much for correcting (and finding) this issue! 🤗🥳

@gschier gschier merged commit e666961 into Kong:develop Feb 18, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
serpilacar added a commit to serpilacar/insomnia that referenced this pull request Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.