Introduce a checkbox in Basic Auth form to choose ISO-8859-1 encoding for credentials.

[jgiovaresco]

Introduce a checkbox in Basic Auth form to choose ISO-8859-1 encoding for credentials.

I had to update network's "Handle Authorization header" to use getAuthHeader instead of libcurl options for Basic Http
because it seems that lib-curl does not let us choose the encoding for Basic Auth credentials

Closes #1558

[nijikokun]

I'm actually wondering if we should follow suit and simply apply UTF-8 encoding by default, and have a checkbox to fallback to the previous encoding.

Actually, after looking through the PR, it appears that the default is utf8 and this is a fallback to latin1. Interesting that utf8 isn't properly encoding french accents as it should (see link above for Firefox reasoning). I suspect the server expects the encoding format from latin1 like the listed exception jboss.

Looks good from a product perspective, with one small suggestion that we put Use in front of the encoding.

[netlify]

Deploy preview for insomnia-storybook ready!

Built with commit 9361c8b

https://deploy-preview-2642--insomnia-storybook.netlify.app

[develohpanda]

Looks good to me, thanks for doing this!

Small change I think is worth addressing, otherwise good to go.

[jgiovaresco]

@develohpanda I've rebased the PR and amended the 1st commit (#fef8cd3) with your suggestions. I let you take a look ;)

[develohpanda]

Nice! 💯

I'm going to merge this in, and will explore adding an end-to-end test for Core in the packages/insomnia-smoke-test project. Feel free to give that a go separately, but it's a little new so there isn't much documentation or instructions as yet.